Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please consider adding license metadata to PyPI #89

Closed
asmith26 opened this issue Nov 9, 2022 · 2 comments · Fixed by #90
Closed

Please consider adding license metadata to PyPI #89

asmith26 opened this issue Nov 9, 2022 · 2 comments · Fixed by #90

Comments

@asmith26
Copy link

asmith26 commented Nov 9, 2022

Hi there,

I'm looking at using fastparquet which seems to have a dependency on cramjam. I'm also using liccheck to check any python packages we use are compatible with our license needs. It looks like this package is licensed under MIT, however because this information is not included in the PyPI package, liccheck is flagging cramjam as "unknown license" (see the META section of cramjam compared with e.g. fastparquet).

I'm not familiar with maturin (which I think is used to build this package), but possibly you need to add something like https://www.maturin.rs/metadata.html#python-project-metadata or https://stackoverflow.com/a/73274312/5179470 ?

Many thanks for any help, and for this great package! :)
@asmith26 asmith26 changed the title Please add license metadata to PyPI Please consider adding license metadata to PyPI Nov 9, 2022
@milesgranger milesgranger mentioned this issue Nov 9, 2022
Merged
milesgranger added a commit that referenced this issue Nov 9, 2022
@milesgranger @messense
Bump pyo3, numpy and expand pyproject.toml (#90)
62458cd 
Closes #89

* Bump pyo3, numpy and expand pyproject.toml
* Update Cargo.toml

Co-authored-by: messense <[email protected]>
@milesgranger
Copy link
Owner

Thank you for the report and helpful information, much appreciated. :)

@milesgranger
Copy link
Owner

Once https://github.com/milesgranger/pyrus-cramjam/actions/runs/3428734703 is finished, 2.6.2 should satisfy your needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump pyo3, numpy and expand pyproject.toml milesgranger/cramjam
2 participants
@asmith26 @milesgranger