source maps: leave source filename intact, add hash to end #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is not rendered useless
|
Very good, thank you! I'll merge and install this later today |
|
I have a better idea: Only append the hash to source map filenames when a script is reloaded. That would drastically decrease the appearance of hashes in source filenames... but I can't import or require 'convert-source-map' in reloading.js, can I? |
|
Yeah sounds good! You can modify this PR if you like. Also could you use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix #141
Simply adds a hash to the end of the existing source filename, rather than completely overwriting the source filename.
Example source file:
src/sub/file.coffeePreviously appeared as:
md5_hash/compiled_destination/file.jsNow appears as:
src/sub/file.coffee?version=md5_hashAdmittedly, adding the hash to the filename will pollute the console somewhat. But long filenames are truncated with '...' in the console & easily ignored. Whereas putting the hash in the path made source browsers nearly useless, since each file appeared in its own unique folder.