Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add extractors for fantia and fanbox #1459
add extractors for fantia and fanbox #1459
Changes from 10 commits
1413e10
3502643
9fac87a
7750441
bf6d6d9
e0fa068
2694c1e
916a7f8
a4c8cc8
0f56a5e
abdcea7
aa4bdb8
4d6b94a
f6006f0
d23835c
7d45676
afd0ee4
b5c81ed
e21c3a4
de0fd08
f149242
cac1316
599a790
7c9e000
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The items returned from
https://api.fanbox.cc/post.listCreator?creatorId=USER&limit=10
appear to be, at least forxub.fanbox.cc
, more or less the same as the single-item results fromhttps://api.fanbox.cc/post.info?postId=ID
(*) It's only missing comments,imageForShare
, and the entries about next/previous posts.If that's true in general (posts with videos, embeds, etc), we don't need to fetch data from
/post.info
for every post and can use the items returned from/post.listCreator
directly.(*) Diff "/post.listCreator" - "/post.info" for post 2059366
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like you are right, at least I couldn't find any posts where listCreator didn't have all the content. Updated the code to use that directly, it's easy enough to change it back if it turns out it's needed.