Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[newgrounds] Image embeds not captured #1033

Closed
God-damnit-all opened this issue Sep 25, 2020 · 2 comments
Closed

[newgrounds] Image embeds not captured #1033

God-damnit-all opened this issue Sep 25, 2020 · 2 comments
Labels
site:feature

Comments

@God-damnit-all
Copy link
Contributor

Sometimes a Newgrounds submission contains extra images that are embedded in the description, like this submission that has one extra image: https://www.newgrounds.com/art/view/sailoryon/yon-dream-buster

gallery-dl doesn't have any way of capturing them, as far as I know.
@mikf mikf closed this as completed in c5e3971 Oct 11, 2020
@God-damnit-all
Copy link
Contributor Author

@mikf It seems there's an edge case where sometimes image embeds start with // but not https:
image

@God-damnit-all
Copy link
Contributor Author

I fixed it changing line 53 to: yield Message.Url, url.replace("https:", "").replace("//", "https://") , post

mikf added a commit that referenced this issue Oct 15, 2020
@mikf
[newgrounds] handle embeds without scheme (#1033)
5b844a7
@mikf mikf mentioned this issue Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
site:feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikf @God-damnit-all