-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to disable "generated" timestamp #784
Comments
Thank you very much for the report @nielsvanvelzen . That's a great suggestion, and makes a lot of sense. The timestamp was introduced to offer teams who only generate new dependency exports on-demand a tool to verify when the given export was generated (to prevent potential build issues where the generation would no longer work) I'll have a look into this, but a configuration option for the plugin will most likely make most sense. |
After a closer look, you can already achieve this right away by
|
Awesome, it does indeed remove the field from the generated JSON. Can I expect this functionality to keep working (e.g. the field won't be required in the runtime part of the library in a later release)? |
There are no plans to use the field as part of the runtime, similarly most other fields are optional and can be dropped to lower size of the meta-data. |
This removes the metadata.generated timestamp in a json file generated by AboutLibraries. This value is not really needed, but breaks reproducible builds, as different timestamps are saved. mikepenz/AboutLibraries#784 (comment) Without this timestamp the app is fully reproducible.
This removes the metadata.generated timestamp in a json file generated by AboutLibraries. This value is not really needed, but breaks reproducible builds, as different timestamps are saved. mikepenz/AboutLibraries#784 (comment) Without this timestamp the app is fully reproducible.
What about making this For example, here is what it looks like when AboutLibraires is the only thing breaking reproducble builds: |
It was a means to help integrators identify when the file was generated the last time. I do agree, though, that most integrating parties might not think about it resulting in non-reproducible builds, and that it is probably best to inverse the default. While not the same simplicity as just dropping in the plugin: |
For the app I'm working on (jellyfin-androidtv) we want to publish builds to F-Droid. Ideally we'd use reproducible builds with that. After the reproducible builds failing for some time I found out this library causes a small issue.
The "res/iz.json" file that is generated contains a timestamp (metadata.generated) which is unique for each build. This makes the build not reproducible.
Would it be possible to add an option to either remove the property / set it to null / hardcode a value?
If you're interested in more reasoning why reproducible builds matter you can read at https://reproducible-builds.org (I'm not the best explainer).
The text was updated successfully, but these errors were encountered: