WIP

mikem8361 · Jul 18, 2022 · bbd7192 · bbd7192
1 parent 071234d
commit bbd7192
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 17 deletions.
diff --git a/src/SOS/lldbplugin/services.cpp b/src/SOS/lldbplugin/services.cpp
@@ -2784,6 +2784,45 @@ LLDBServices::AddCommand(
     return command;
 }
 
+bool
+LLDBServices::ExecuteCommand(
+    const char* commandName,
+    char** arguments,
+    lldb::SBCommandReturnObject &result)
+{
+    std::string commandLine;
+    commandLine.append(commandName);
+    commandLine.append(" ");
+    for (const char* arg = *arguments; arg != nullptr; arg = *(++arguments))
+    {
+        commandLine.append(arg);
+        commandLine.append(" ");
+    }
+    if (m_commands.find(commandName) == m_commands.end())
+    {
+        lldb::ReturnStatus status = m_interpreter.HandleCommand(commandLine.c_str(), result);
+        result.SetStatus(status);
+        return true;
+    }
+    IHostServices* hostservices = GetHostServices();
+    if (hostservices != nullptr)
+    {
+        g_services->FlushCheck();
+        HRESULT hr = hostservices->DispatchCommand(commandLine.c_str());
+        if (hr != S_OK)
+        {
+            result.SetStatus(lldb::eReturnStatusFailed);
+        }
+        else 
+        {
+            result.SetStatus(lldb::eReturnStatusSuccessFinishResult);
+        }
+        return true;
+    }
+    // This means command not found
+    return false;
+}
+
 HRESULT 
 LLDBServices::InternalOutputVaList(
     ULONG mask,

diff --git a/src/SOS/lldbplugin/services.h b/src/SOS/lldbplugin/services.h
@@ -414,5 +414,7 @@ class LLDBServices : public ILLDBServices, public ILLDBServices2, public IDebugg
 
     lldb::SBCommand AddCommand(const char *name, lldb::SBCommandPluginInterface *impl, const char *help);
 
+    bool ExecuteCommand( const char* commandName, char** arguments, lldb::SBCommandReturnObject &result);
+
     HRESULT InternalOutputVaList(ULONG mask, PCSTR format, va_list args);
 };
diff --git a/src/SOS/lldbplugin/soscommand.cpp b/src/SOS/lldbplugin/soscommand.cpp
@@ -48,24 +48,9 @@ class sosCommand : public lldb::SBCommandPluginInterface
             else
             {
                 sosCommand = *arguments++;
-
-                IHostServices* hostservices = GetHostServices();
-                if (hostservices != nullptr)
+                if (g_services->ExecuteCommand(sosCommand, arguments, result))
                 {
-                    std::string commandLine;
-                    commandLine.append(sosCommand);
-                    commandLine.append(" ");
-                    for (const char* arg = *arguments; arg != nullptr; arg = *(++arguments))
-                    {
-                        commandLine.append(arg);
-                        commandLine.append(" ");
-                    }
-                    g_services->FlushCheck();
-                    HRESULT hr = hostservices->DispatchCommand(commandLine.c_str());
-                    if (hr == S_OK)
-                    {
-                        return result.Succeeded();
-                    }
+                    return result.Succeeded();
                 }
             }
         }