Remove downcase! method from sanitize function in ContentTypeField #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes mikel#1398 This change removes the sequence of code that downcases the Content-Type header value. If I should believe the specs, it should serve no purpose. Only 2 specs break because of the charset being returned in capital letters instead of downcased as before. This fixes the problem is which encoding is broken by downcasing, such as the example with base64 provided in mikel#1398
|
nice find! I think you're right, the code should be removed. Could you add a test case according to your example to avoid further regressions? |
|
Hi there @RemcodM could you please rebase this onto latest master? This will then trigger all the current specs we have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1398
This change removes the sequence of code that downcases the Content-Type header value. If I should believe the specs, it should serve no purpose. Only 2 specs break because of the charset being returned in capital letters instead of downcased as before.
This fixes the problem is which encoding is broken by downcasing, such as the example with base64 provided in #1398