Optimize percentile calculation (#67)

mikejihbe · Jan 3, 2019 · 16c72e6 · 16c72e6
1 parent c0f9e33
commit 16c72e6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 13 deletions.
diff --git a/lib/binary_heap.js b/lib/binary_heap.js
@@ -11,11 +11,8 @@ var BinaryHeap = module.exports = function BinaryHeap(scoreFunction){
 
 BinaryHeap.prototype = {
 
-  clone: function() {
-    var heap = new BinaryHeap(this.scoreFunction);
-    // A little hacky, but effective.
-    heap.content = JSON.parse(JSON.stringify(this.content));
-    return heap;
+  getValues: function() {
+    return this.content;
   },
 
   push: function(element) {

diff --git a/stats/exponentially_decaying_sample.js b/stats/exponentially_decaying_sample.js
@@ -14,15 +14,9 @@ var ExponentiallyDecayingSample = module.exports = function ExponentiallyDecayin
 
 ExponentiallyDecayingSample.prototype = new Sample();
 
-// This is a relatively expensive operation
+// The result is not sorted in a meaningful order.
 ExponentiallyDecayingSample.prototype.getValues = function() {
-  var values = []
-    , elt
-    , heap = this.values.clone();
-  while(elt = heap.pop()) {
-    values.push(elt.val);
-  }
-  return values;
+  return this.values.getValues().map(function(v) { return v.val; });
 }
 
 ExponentiallyDecayingSample.prototype.size = function() {