Skip to content

Commit

Permalink
ansible-collections#1573 fix linting errors
Browse files Browse the repository at this point in the history
  • Loading branch information
mikehas committed Oct 27, 2022
1 parent c3cadd1 commit 319be49
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
10 changes: 5 additions & 5 deletions plugins/modules/ssm_parameter.py
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ def create_update_parameter(client, module):
_wait_updated(client, module, module.params.get('name'), original_version)
# import time
# time.sleep(300)

# Handle tag updates for existing parameters
if (module.params.get('overwrite_value') != 'never'):
tags_changed, tags_response = update_parameter_tags(client, module,
Expand All @@ -500,12 +500,12 @@ def create_update_parameter(client, module):
response['tag_updates'] = tags_response


else:
else:
# Add tags in initial creation request
if (module.params.get('tags')):
args.update(Tags=ansible_dict_to_boto3_tag_list(module.params.get('tags')))
# Overwrite=True conflicts with tags and is not needed for new param
args.update(Overwrite=False)
args.update(Tags=ansible_dict_to_boto3_tag_list(module.params.get('tags')))
# Overwrite=True conflicts with tags and is not needed for new param
args.update(Overwrite=False)

(changed, response) = update_parameter(client, module, **args)
_wait_exists(client, module, module.params.get('name'))
Expand Down
3 changes: 1 addition & 2 deletions tests/integration/targets/ssm_parameter/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1492,5 +1492,4 @@
ignore_errors: True
with_items:
- '{{ simple_name }}'
- '{{ simple_tag_param_name }}'

- '{{ simple_tag_param_name }}'

0 comments on commit 319be49

Please sign in to comment.