Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to send custom HTTP headers #366

Closed
mikehaertl opened this issue Mar 1, 2021 · 4 comments
Closed

Allow to send custom HTTP headers #366

mikehaertl opened this issue Mar 1, 2021 · 4 comments

Comments

@mikehaertl
Copy link
Owner

See mikehaertl/php-tmpfile#26.

We can add another arg $headers to the send() method in the Pdf and Image class, too.
mikehaertl added a commit that referenced this issue Mar 1, 2021
@mikehaertl
Issue #366 Allow to pass additional headers to send()
f8ca5bb
@mikehaertl mikehaertl mentioned this issue Mar 1, 2021
Closed
@PedroPMS
Copy link

PedroPMS commented Mar 1, 2021

Great, I will do some tests like this I did in php-tmpfile.

@PedroPMS
Copy link

PedroPMS commented Mar 1, 2021

It worked really well too.

Pdf
image
image

Image
image
image

mikehaertl added a commit that referenced this issue Mar 1, 2021
@mikehaertl
Issue #366 Allow to pass additional headers to send()
b75971b
@mikehaertl mikehaertl mentioned this issue Mar 1, 2021
Merged
mikehaertl added a commit that referenced this issue Mar 1, 2021
@mikehaertl
Merge pull request #367 from mikehaertl/366-allow-custom-http-header
17ee713 
Issue #366 Allow to pass additional headers to send()
@mikehaertl
Copy link
Owner Author

Cool. I've just released 2.5.0 including this change. Thanks for the suggestion and your help!

@PedroPMS
Copy link

PedroPMS commented Mar 1, 2021

It was a pleasure to help. Thank you for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikehaertl @PedroPMS