-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading to version 0.10.2 makes our test fail #249
Comments
Release 0.10.2 only contained a little change in how form data is processed. It should be backward compatible (see here). If that's really the problem please provide a short code example to reproduce the problem. If not, what is the last version that worked for you? I don't know what you do in your CI tests but you could also check our relase notes if there's any suspicious change that matches your test cases: https://github.com/mikehaertl/php-pdftk/releases Also check these two underlying packages and try to revert to older versions: |
To identify the version causing the issue, we locked all our dependency versions:
I'm not sure that the change you made are backward compatible. To me, there is an infinite loop.
Let's say I call the method with
In the foreach loop, I'm not sure to understand the isset check. Isn't
better ? At least, if the check you want to do is really about the key |
@mikehaertl If I'm right, the test #250 should fail. |
We also noticed infinite recursion errors happening after upgrading to version 0.10.2. |
Oh, I see, sorry for the hassle. I've pushed a fix in #251 and also test for @VincentLanglet The thing is that we also must support nested (a.k.a. hierarchical) fields: In PDF forms a field can contain other fields, for example an The other case are multi select fields (added in 0.10.2, see #148). That's fields with multiple values. Here the value will also be an array but have numeric keys. To differ between the two we check if a |
Issue #249 Fix infinite loop with null values in form data
Release 0.10.3 is out and includes a fix. Thanks for the help. |
Hello @mikehaertl, we use pdftk for a long time in our project and it worked great until we tried to upgrade to version 0.10.2.
The Github CI fails with this message:
"Error: Process completed with exit code 137."
Any idea about what should be done ?
The text was updated successfully, but these errors were encountered: