Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow for null value in deserialized node #55

Merged
merged 3 commits into from
Nov 25, 2019
Merged

fix: allow for null value in deserialized node #55

merged 3 commits into from
Nov 25, 2019

Conversation

alanshaw
Copy link

@alanshaw alanshaw commented Nov 25, 2019

typeof null is 'object'

Fixes:

TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at /Users/alan/Code/pl/ipfs/js-ipfs/node_modules/dag-cbor-links/index.js:10:28
    at Generator.next (<anonymous>)
    at /Users/alan/Code/pl/ipfs/js-ipfs/node_modules/dag-cbor-links/index.js:30:21
    at Generator.next (<anonymous>)
    at /Users/alan/Code/pl/ipfs/js-ipfs/src/core/components/pin/pin-manager.js:62:34
    at async run (/Users/alan/Code/pl/ipfs/js-ipfs/node_modules/p-queue/dist/index.js:255:29)

Depends on:

@mikeal mikeal merged commit c9bc4ab into mikeal:master Nov 25, 2019
@mikeal
Copy link
Owner

mikeal commented Nov 25, 2019

Published 1.3.2

@alanshaw alanshaw deleted the fix/null-value branch November 25, 2019 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants