Make dat homeRoute customizable!!! #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test coverage please |
|
@truenorth... Hrmmm... |
|
@truenorth nvm... I haz hack |
Make dat homeRoute customizable!!! Added tests to check that a custom navbar homeRoute can be defined
rtablada
force-pushed
the
feature-customize-home-route
branch
from
65bbcbb to
ef642bb
Compare
|
@truenorth tests are running now! Also went ahead and squashed them there commits. |
|
|
mike-north
added a commit
that referenced
this pull request
Jul 17, 2015
Make dat homeRoute customizable!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you rename the home route from index to something else (such as namespacing it all under a
dashboardroute) then all hell breaks loose! Let's fix that.