feat: reintroduce cjs support via bundling #98
Conversation
|
Cool. Checking out now. |
|
Would this require peer dependency of 4.0.2 or over? |
|
peerDep of |
|
Oh wait, I'm pushing a tiny improvement to "exports" to match info at: |
|
You're right, thinking about it more if using 4.0.0 you can still use this and then choose the ESM edition. So works as before. Tested out locally and seems to work as expected! Was looking into and verifying the exports property aswell. Good suggestion to update it! Awaiting commit |
use nested conditions to allow bundling `marked-terminal`. it would fallback to "default", per https://nodejs.org/dist/latest-v16.x/docs/api/packages.html#nested-conditions also added "browser" field for older bundlers not supporting "exports"
|
Pushed. 👍 |
|
Thanks! Good work 🍰 |
|
@mikaelbr I forget to add "index.cjs" to the "files" field of package.json :( just checked 5.1.0 and published package doesn't include it. my bad. |
|
Hah, dang it. I should have checked that. I packaged it up but was to lazy to check contents 🤦 I'll fix it |
|
|
closes #97