-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace gulp-util with alternatives #124
Conversation
package.json
Outdated
"through2": "^2.0.3" | ||
"plugin-error": "^0.1.2", | ||
"through2": "^2.0.3", | ||
"vinyl": "^2.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vinyl
should be in the devDependencies
, it is only used for the tests.
Please update it: it is important to avoid unnecessary dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I tweaked it. 46efdc6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the PR should be fine now.
Thanks for the PR, I had some issues with the tests and did not have time to look into this yesterday. @mikaelbr Could we have this merged? |
🎉 thanks! |
@mikaelbr Thank you too! |
@mikaelbr Can this be published to npm? ^_^ thanks! |
Indeed!
|
Hello gulp-notify maintainers.
Following gulpjs/gulp-util#143, I dropped dependency on gulp-util.
closes #123
Thanks!