Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues when reading/saving images #993

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

FooIbar
Copy link
Contributor

@FooIbar FooIbar commented Jul 8, 2024

Avoid using platform mime type map to get extensions as it may not have all mime types we support.

This also fixes the performance issue of reading jxl archives, wrong file extensions and can't open downloaded files.

Fixes #566

Avoid using platform mime type map to get extensions as it may not have
all mime types we support.
@AntsyLich AntsyLich changed the title Fix unsupported mime type error when saving images Fix some issues when reading/saving images Jul 8, 2024
@AntsyLich AntsyLich merged commit daa47e0 into mihonapp:main Jul 8, 2024
1 check passed
cuong-tran pushed a commit to komikku-app/komikku that referenced this pull request Jul 8, 2024
(mihonapp/mihon#993)

* Fix unsupported mime type error when saving images

Avoid using platform mime type map to get extensions as it may not have
all mime types we support.

* Fix jxl images downloading/reading

(cherry picked from commit daa47e0)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to open Jpeg XL (.jxl) files unless saved as CBZ
2 participants