Fix repo name used for URL instead of baseUrl #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies to both the item being shown in the screen as well as the "copy to clipboard" button. Before, copying a repo url would return "The Repo Name/index.json.min". This PR fixes that.
Passing the whole ExtensionRepo data class through now, using the name for display purposes and the baseUrl for copying the URL.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies to both the item being shown in the screen as well as the “copy to clipboard” button. Before, copying a repo URL would return “The Repo Name/index.json.min”. This PR fixes that.
Edit: I misunderstood the original intent, now the whole ExtensionRepo is passed to the item display, which uses the name for displaying and the baseUrl for copying the URL.