Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shizuku being buggy for multi user setups #494

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

Redjard
Copy link
Contributor

@Redjard Redjard commented Mar 8, 2024

Fixes bug #493.
I have successfully tested this fix by building and installing the app on my phone.
Fetch the current userid separately because shizuku always runs as the main user and would otherwise install and update for the main user

Fetch the current userid separately because shizuku always runs as the main user and would otherwise install and update for the main user
@Redjard Redjard changed the title Fix #493 Fix #493 (Extension install via shizuku applied to wrong userid in multiuser environment) Mar 8, 2024
@AntsyLich AntsyLich changed the title Fix #493 (Extension install via shizuku applied to wrong userid in multiuser environment) Fix shizuku being buggy for multi user setups Mar 9, 2024
@AntsyLich AntsyLich merged commit 402e579 into mihonapp:main Mar 9, 2024
1 check passed
@Redjard Redjard deleted the patch-493-shizuku-userid branch March 9, 2024 19:14
AntsyLich added a commit to kaiserbh/mihon that referenced this pull request Mar 9, 2024
* Fix mihonapp#493

Fetch the current userid separately because shizuku always runs as the main user and would otherwise install and update for the main user

* Update app/src/main/java/eu/kanade/tachiyomi/extension/installer/ShizukuInstaller.kt

---------

Co-authored-by: AntsyLich <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants