Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made some changes to ComicInfo metadata #459

Merged
merged 10 commits into from
Feb 29, 2024

Conversation

Shamicen
Copy link
Contributor

I made some changes to ComicInfo metadata generation:

The web field had a schema change and can now contain multiple space separated reference website links. Therefore ComicInfo metadata will from now on include the source URL and all available tracker URLs.
For more information look at this issue anansi-project/comicinfo#56 and this PR anansi-project/comicinfo#57

I changed the translator field to use the source name if no scanlator name is available.

The web field now contains a " " separated list of source and tracker urls.
The translator field will now use the source name if the scanlator field is empty.
@AntsyLich
Copy link
Member

I changed the translator field to use the source name if no scanlator name is available.

Not sure i like that change

@Shamicen
Copy link
Contributor Author

Shamicen commented Feb 28, 2024

I was planning to make it so that LocalSource chapters will appear with their metadata in the future.

As of now we would be unable to display a scanlator for most sources, because a lot of them don't populate the scanlator field with their name if they are also the scanlators.

Their are also a few aggregator sources that already "incorrectly" populate the scanlator field with their source name.

For use inside Mihon the field will only show up in LocalSource and even if the source wasn't the original scanlator seeing which source the manga is from looks better / gives the user more information then just leaving it blank.

We could make it standard policy for sources that are also scanlators to populate the scanlator field with their source name and for sources that aren't to not populate it, if we don't want to risk "wrong" translator names. Whether or not the 3rd party extension will actually follow it is a different question but it can't hurt to try.

We could alternatively create another non schema field and use this for our LocalSource when no scanlator is available.

Tell me what you think and I'll make the necessary changes.

@AntsyLich
Copy link
Member

Could do a custom field then for source and in local source do scanlator ?: mihon_source

created new Mihon exclusive ComicInfo source field  and populated it with SourceName

reverted previous changes to translator field
@Shamicen
Copy link
Contributor Author

Could do a custom field then for source

I implemented it

@AntsyLich AntsyLich merged commit 4bfc5e7 into mihonapp:main Feb 29, 2024
1 check passed
AntsyLich added a commit to kaiserbh/mihon that referenced this pull request Mar 9, 2024
* Made some changes to ComicInfo metadata

The web field now contains a " " separated list of source and tracker urls.
The translator field will now use the source name if the scanlator field is empty.

* lint

* use already existing source instance

* made translator not nullable

* implemented requested changes

created new Mihon exclusive ComicInfo source field  and populated it with SourceName

reverted previous changes to translator field

* Update core-metadata/src/main/java/tachiyomi/core/metadata/comicinfo/ComicInfo.kt

Co-authored-by: AntsyLich <[email protected]>

* Update app/src/main/java/eu/kanade/domain/manga/model/Manga.kt

Co-authored-by: AntsyLich <[email protected]>

* Update app/src/main/java/eu/kanade/domain/manga/model/Manga.kt

Co-authored-by: AntsyLich <[email protected]>

* Update app/src/main/java/eu/kanade/tachiyomi/data/download/Downloader.kt

Co-authored-by: AntsyLich <[email protected]>

* Update app/src/main/java/eu/kanade/tachiyomi/data/download/Downloader.kt

---------

Co-authored-by: AntsyLich <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants