-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made some changes to ComicInfo metadata #459
Conversation
The web field now contains a " " separated list of source and tracker urls. The translator field will now use the source name if the scanlator field is empty.
Not sure i like that change |
I was planning to make it so that As of now we would be unable to display a scanlator for most sources, because a lot of them don't populate the Their are also a few aggregator sources that already "incorrectly" populate the scanlator field with their source name. For use inside We could make it standard policy for sources that are also scanlators to populate the scanlator field with their source name and for sources that aren't to not populate it, if we don't want to risk "wrong" translator names. Whether or not the 3rd party extension will actually follow it is a different question but it can't hurt to try. We could alternatively create another non schema field and use this for our Tell me what you think and I'll make the necessary changes. |
Could do a custom field then for source and in local source do |
created new Mihon exclusive ComicInfo source field and populated it with SourceName reverted previous changes to translator field
I implemented it |
core-metadata/src/main/java/tachiyomi/core/metadata/comicinfo/ComicInfo.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/data/download/Downloader.kt
Outdated
Show resolved
Hide resolved
…ComicInfo.kt Co-authored-by: AntsyLich <[email protected]>
Co-authored-by: AntsyLich <[email protected]>
Co-authored-by: AntsyLich <[email protected]>
Co-authored-by: AntsyLich <[email protected]>
app/src/main/java/eu/kanade/tachiyomi/data/download/Downloader.kt
Outdated
Show resolved
Hide resolved
* Made some changes to ComicInfo metadata The web field now contains a " " separated list of source and tracker urls. The translator field will now use the source name if the scanlator field is empty. * lint * use already existing source instance * made translator not nullable * implemented requested changes created new Mihon exclusive ComicInfo source field and populated it with SourceName reverted previous changes to translator field * Update core-metadata/src/main/java/tachiyomi/core/metadata/comicinfo/ComicInfo.kt Co-authored-by: AntsyLich <[email protected]> * Update app/src/main/java/eu/kanade/domain/manga/model/Manga.kt Co-authored-by: AntsyLich <[email protected]> * Update app/src/main/java/eu/kanade/domain/manga/model/Manga.kt Co-authored-by: AntsyLich <[email protected]> * Update app/src/main/java/eu/kanade/tachiyomi/data/download/Downloader.kt Co-authored-by: AntsyLich <[email protected]> * Update app/src/main/java/eu/kanade/tachiyomi/data/download/Downloader.kt --------- Co-authored-by: AntsyLich <[email protected]>
I made some changes to
ComicInfo
metadata generation:The
web field
had a schema change and can now contain multiple space separated reference website links. Therefore ComicInfo metadata will from now on include thesource URL
and all availabletracker URLs
.For more information look at this issue anansi-project/comicinfo#56 and this PR anansi-project/comicinfo#57
I changed the
translator field
to use the source name if noscanlator
name is available.