Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Introduce Upcoming page to Mihon #420

Merged
merged 41 commits into from
Mar 28, 2024

Conversation

sirlag
Copy link
Contributor

@sirlag sirlag commented Feb 18, 2024

Draft Notes

  • This feature probably still requires some tweaking to the smart updates estimates / what is shown. Currently, ongoing manga that are effectively finished or on hiatus but not marked as such will still display (and register with smart updates), sometimes with rather short estimates.
  • This is my first major contribution to Mihon, I am almost certain I missed something, code review / change requests are appreciated.
  • Possibly tweak the list items further

Features

  • Adds new "Upcoming" screen which will allow users to see what manga may be releasing in the near future, powered by the smart updates system.
  • Displays upcoming updates in both a calendar and list view.

Interactions

  • Open the Upcoming screen by pressing the calendar in the app bar of the Updates tab
  • Exit the screen through the back button or system gestures
  • The question mark in the top right will open a help guide to explain the smart updates system / what is actually being shown
    • If this feature is planned to be merged, I will write the copy for this and make a matching PR to the web repo.
  • Touching a given manga will open the associated manga library entry
  • Touching a date on the calendar with fast scroll to updates planned for that day, if there are any present.

Screenshots

Update Tab Upcoming Screen
image image
Horizontal Extended View Vertical Extended View
image image
Horizontal Tablet UI Vertical Tablet UI
image image

Video Demo: https://github.com/mihonapp/mihon/assets/1882979/6945a4dc-c987-418d-9d70-c7bcefe1c9e6

@sirlag sirlag changed the title Introduce Upcoming page to New Feature: Introduce Upcoming page to Mihon Feb 18, 2024
@sirlag
Copy link
Contributor Author

sirlag commented Feb 18, 2024

Updated the tablet view as well as provided tablet specific screenshots. There is space for two months side by side on the horizontal tablet view, but I was having difficulty getting the page to behave as wanted.

@sirlag sirlag marked this pull request as ready for review February 18, 2024 21:49
@AntsyLich
Copy link
Member

Maybe for tablet view have calendar and list side by side? similar to the manga details screen where info is on one side and chapter list on other. we have a component for this 2 sided behavior so check that out

@sirlag sirlag requested a review from AntsyLich March 22, 2024 18:30
@sirlag sirlag requested a review from AntsyLich March 22, 2024 21:02
@sirlag sirlag requested a review from AntsyLich March 23, 2024 16:37
@sirlag sirlag requested a review from AntsyLich March 26, 2024 02:58
@sirlag sirlag requested a review from AntsyLich March 27, 2024 18:31
@AntsyLich AntsyLich merged commit 72222ad into mihonapp:main Mar 28, 2024
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants