Added random library sort #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackhamilton
commented
Oct 12, 2024
domain/src/main/java/tachiyomi/domain/library/service/LibraryPreferences.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt
Outdated
Show resolved
Hide resolved
AntsyLich
requested changes
Oct 12, 2024
app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/presentation/library/LibrarySettingsDialog.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/tachiyomi/domain/library/model/LibrarySortMode.kt
Outdated
Show resolved
Hide resolved
presentation-core/src/main/java/tachiyomi/presentation/core/components/SettingsItems.kt
Outdated
Show resolved
Hide resolved
…gsDialog.kt Co-authored-by: AntsyLich <[email protected]>
…Model.kt Co-authored-by: AntsyLich <[email protected]>
|
Thanks for the review, learned return@ and that you can throw an error from a switch instead of making it nullable. Updates made. |
AntsyLich
requested changes
Oct 12, 2024
app/src/main/java/eu/kanade/presentation/library/LibrarySettingsDialog.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/tachiyomi/domain/library/model/LibrarySortMode.kt
Outdated
Show resolved
Hide resolved
…gsDialog.kt Co-authored-by: AntsyLich <[email protected]>
AntsyLich
requested changes
Oct 12, 2024
app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryScreenModel.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/tachiyomi/domain/library/service/LibraryPreferences.kt
Outdated
Show resolved
Hide resolved
|
ALso make sure to run |
AntsyLich
changed the title
…Model.kt Co-authored-by: AntsyLich <[email protected]>
…references.kt Co-authored-by: AntsyLich <[email protected]>
Has this been considered as a precommit hook? Would save having to remember to do it. I can PR that if it's something you'd like. Only asterisk is that runtime's a bit long, but if we should be running it all the time anyway, it might be a good idea. |
|
Just to confirm. Clicking "Random" while it's active changes the sort? |
That's right, yeah |
|
swear I made that change already but that should fix (the?) failing unit test |
AntsyLich
approved these changes
Oct 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing #1315 because I was using my main branch like a goon
Problem:
If you have a large bulk from a source that uses something that interferes with alphabetical tagging - e.g. a comic source that leads its releases with the year ([2019], ex), the sort options will group every title like that together when, personally, I've found I sometimes want to view my library in a way that scatters them more evenly. Sometimes I don't want to view my stuff chronologically.
Also I just like random sort.
Behavior:
Using a single random seed for all categories. The seed for all categories using random sort will change any time a section switches to random or taps on the randomization again. I believe this should line up with expected behavior and that users don't expect a distinctly saved random ordering for each tab, but I'm open to discussion there.
Images