Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format Category String on Subtitle Display #1030

Merged
merged 5 commits into from
Jul 25, 2024
Merged

Conversation

Animeboynz
Copy link
Contributor

@Animeboynz Animeboynz commented Jul 19, 2024

Category Names that cause crashes Fixes #1029

  • Anything that ends in %
  • %c
  • %d
  • %e
  • %f
  • %g
  • %o
  • %t
  • %x

Category Names that cause weird behavior

  • %b - Displays True
    image
  • %h - Displays 4e3
    image
  • %n - Adds a newline
    image
    image
    image

Category Names that work

  • %s

Crash occurs when category with said name is set as default category.

@Animeboynz Animeboynz changed the title Fixes #1029 Format Category String on Subtitle Display Jul 20, 2024
@FooIbar
Copy link
Contributor

FooIbar commented Jul 24, 2024

It's not necessary, just remove this line

subtitle = selectedCategory?.visualName ?: stringResource(MR.strings.default_category_summary),

@AntsyLich
Copy link
Member

Why not just override subtitleProvider?

@AntsyLich AntsyLich merged commit 88efde8 into mihonapp:main Jul 25, 2024
1 check passed
cuong-tran pushed a commit to komikku-app/komikku that referenced this pull request Jul 26, 2024
* Fixes mihonapp/mihon#1029

* Max Line Length Fix

* Update SettingsLibraryScreen.kt

No idea how this works.

Co-authored-by: Foolbar <[email protected]>

---------

Co-authored-by: Foolbar <[email protected]>
(cherry picked from commit 88efde8)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using % in a default category crashes screen: More > Settings > Library
3 participants