Ignore catch-all namespace in client connections (Fixes #1351)

miguelgrinberg · Jun 18, 2024 · 469b7c0 · 469b7c0
1 parent d67a272
commit 469b7c0
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 0 deletions.
diff --git a/src/socketio/async_client.py b/src/socketio/async_client.py
@@ -128,6 +128,8 @@ async def connect(self, url, headers={}, auth=None, transports=None,
         if namespaces is None:
             namespaces = list(set(self.handlers.keys()).union(
                 set(self.namespace_handlers.keys())))
+            if '*' in namespaces:
+                namespaces.remove('*')
             if len(namespaces) == 0:
                 namespaces = ['/']
         elif isinstance(namespaces, str):

diff --git a/src/socketio/client.py b/src/socketio/client.py
@@ -126,6 +126,8 @@ def connect(self, url, headers={}, auth=None, transports=None,
         if namespaces is None:
             namespaces = list(set(self.handlers.keys()).union(
                 set(self.namespace_handlers.keys())))
+            if '*' in namespaces:
+                namespaces.remove('*')
             if len(namespaces) == 0:
                 namespaces = ['/']
         elif isinstance(namespaces, str):

diff --git a/tests/async/test_client.py b/tests/async/test_client.py
@@ -98,6 +98,7 @@ def test_connect_default_namespaces(self):
         c.eio.connect = AsyncMock()
         c.on('foo', mock.MagicMock(), namespace='/foo')
         c.on('bar', mock.MagicMock(), namespace='/')
+        c.on('baz', mock.MagicMock(), namespace='*')
         _run(
             c.connect(
                 'url',

diff --git a/tests/common/test_client.py b/tests/common/test_client.py
@@ -236,6 +236,7 @@ def test_connect_default_namespaces(self):
         c.eio.connect = mock.MagicMock()
         c.on('foo', mock.MagicMock(), namespace='/foo')
         c.on('bar', mock.MagicMock(), namespace='/')
+        c.on('baz', mock.MagicMock(), namespace='*')
         c.connect(
             'url',
             headers='headers',