Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix main tests due to tests not cleaning data created by itself #149

Merged
merged 11 commits into from
Nov 2, 2021
Merged

Fix main tests due to tests not cleaning data created by itself #149

merged 11 commits into from
Nov 2, 2021

Conversation

carlosthe19916
Copy link
Contributor

No description provided.

@carlosthe19916 carlosthe19916 added the wip work in progress label Nov 2, 2021
@carlosthe19916 carlosthe19916 changed the title Remove cache [WIP]: Fix main tests Nov 2, 2021
@codecov
Copy link

codecov bot commented Nov 2, 2021 •
edited
Loading

Codecov Report

Merging #149 (753291f) into main (e03f379) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #149   +/-   ##
=========================================
  Coverage     97.47%   97.47%           
  Complexity      322      322           
=========================================
  Files            32       32           
  Lines           595      595           
  Branches         36       36           
=========================================
  Hits            580      580           
  Misses           12       12           
  Partials          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e03f379...753291f. Read the comment docs.

@carlosthe19916 carlosthe19916 changed the title [WIP]: Fix main tests [WIP]: Fix main tests due to tests not cleaning data created by itself Nov 2, 2021
@carlosthe19916 carlosthe19916 added Ready for review and removed wip work in progress labels Nov 2, 2021
@carlosthe19916 carlosthe19916 requested a review from mrizzi November 2, 2021 16:51
@mrizzi mrizzi changed the title [WIP]: Fix main tests due to tests not cleaning data created by itself Fix main tests due to tests not cleaning data created by itself Nov 2, 2021
mrizzi
mrizzi approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are now working @carlosthe19916: thanks a lot 👍

@mrizzi mrizzi merged commit ec659e0 into migtools:main Nov 2, 2021
@carlosthe19916 carlosthe19916 mentioned this pull request Nov 3, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrizzi mrizzi mrizzi approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlosthe19916 @mrizzi