Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TACKLE-192] - Bulk copy Assessment/Review #142

Merged
merged 5 commits into from
Oct 29, 2021

Conversation

carlosthe19916
Copy link
Contributor

@carlosthe19916 carlosthe19916 commented Oct 11, 2021

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #142 (504c3e3) into main (2af484e) will decrease coverage by 0.17%.
The diff coverage is 96.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #142      +/-   ##
============================================
- Coverage     97.65%   97.47%   -0.18%     
- Complexity      296      322      +26     
============================================
  Files            26       32       +6     
  Lines           511      595      +84     
  Branches         34       36       +2     
============================================
+ Hits            499      580      +81     
- Misses            9       12       +3     
  Partials          3        3              
Impacted Files Coverage Δ
...o/tackle/applicationinventory/entities/Review.java 100.00% <ø> (ø)
...le/applicationinventory/dto/utils/EntityToDTO.java 88.88% <88.88%> (ø)
...ioninventory/resources/ReviewBulkCopyResource.java 94.44% <94.44%> (ø)
...tackle/applicationinventory/dto/BulkReviewDto.java 100.00% <100.00%> (ø)
.../applicationinventory/entities/BulkCopyReview.java 100.00% <100.00%> (ø)
...ationinventory/entities/BulkCopyReviewDetails.java 100.00% <100.00%> (ø)
...ationinventory/services/BulkCopyReviewService.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2af484e...504c3e3. Read the comment docs.

@carlosthe19916 carlosthe19916 changed the title Bulk copy [TACKLE-192] - Bulk copy Assessment/Review Oct 18, 2021
Copy link
Contributor

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully while for the code review basically we decided to go with "consistency first" approach inheriting the tackle-pathfinder approach so not so much to discuss then.

Thanks @carlosthe19916 👍

@mrizzi mrizzi merged commit e03f379 into migtools:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants