fix(useformstate): properly assert that field types inferred from yup schema are defined #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #60 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 19 19
Branches 5 5
=========================================
Hits 19 19 Continue to review full report at Codecov.
|
|
🚀 Deployed Storybook Preview: http://konveyor-lib-ui-pr-60-preview.surge.sh ✨ |
mturley
force-pushed
the
yup-schema-fixes
branch
from
82d882b to
9ce52ba
Compare
… schema are defined Also adds a "Complex field types and validations" example to the docs
mturley
force-pushed
the
yup-schema-fixes
branch
from
9ce52ba to
4835620
Compare
|
🎉 This PR is included in version 4.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a "Complex field types and validations" example to the docs.
After #59, I realized that a schema e.g.
yup.mixed<T>()would cause TypeScript to infer the field type asT | undefined. This is especially annoying for things like arrays where it would expect every element to be possibly undefined. To prevent ripple effects on all form code that previously assumed field values are always defined unless specified otherwise, I changed the type annotations onuseFormFieldsuch thatTwill always be inferred as a defined value.The side effect of this is that it is now invalid to allow undefined field values in
useFormState, but that is an antipattern anyway, because null should be used for intentionally blank fields.Required for an upcoming forklift-ui PR.