Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(index): Add warnings about moving package to @migtools/lib-ui #110

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

mturley
Copy link
Collaborator

@mturley mturley commented Aug 23, 2022

Adds console warnings and an Alert at the top of every Storybook docs page regarding the move to the @migtools/lib-ui package name.

In the console:
Screen Shot 2022-08-23 at 12 35 19 PM

In Storybook:
Screen Shot 2022-08-23 at 12 21 25 PM

@mturley mturley requested a review from a team August 23, 2022 16:39
@konveyor-preview-bot
Copy link

🚀 Deployed Storybook Preview: http://konveyor-lib-ui-pr-110-preview.surge.sh

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@7393042). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main      #110   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         1           
  Lines           ?        19           
  Branches        ?         5           
========================================
  Hits            ?        19           
  Misses          ?         0           
  Partials        ?         0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@ibolton336 ibolton336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mturley mturley merged commit 66ce1b0 into migtools:main Aug 23, 2022
@mturley mturley deleted the package-moved-warnings branch August 23, 2022 16:59
@konveyor-release-bot
Copy link

🎉 This PR is included in version 8.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

mturley added a commit to mturley/migtools-lib-ui that referenced this pull request Aug 23, 2022
mturley added a commit that referenced this pull request Aug 23, 2022
* Revert "feat(index): add warnings about moving package to `@migtools/lib-ui` (#110)"

This reverts commit 66ce1b0.

* Update GitHub Actions workflows

* Remove outdated CODEOWNERS for now

* Rename mentions of konveyor to migtools

* Refresh token on migtools-preview-bot

* Rename workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants