Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some post-rc1 fixes #987

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Some post-rc1 fixes #987

merged 4 commits into from
Oct 6, 2023

Conversation

vyzo
Copy link
Collaborator

@vyzo vyzo commented Oct 6, 2023

  • Fixes clown shoes with double v in configured gerbil version
  • kills obsolete release.ss script; it is not useful any more
  • adds a runtime initialized indicator and sanity checks it when trying to load the expander

vyzo added 3 commits October 6, 2023 12:38
So that if the programmer makes the mistake of calling
gerbil-load-expander! outside main he gets a useful error message.
@vyzo vyzo requested a review from fare October 6, 2023 09:44
@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for elastic-ritchie-8f47f9 ready!

Name Link
🔨 Latest commit c4aefc6
🔍 Latest deploy log https://app.netlify.com/sites/elastic-ritchie-8f47f9/deploys/651ff88b8ba4a900080f1c7d
😎 Deploy Preview https://deploy-preview-987--elastic-ritchie-8f47f9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@fare fare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

But why can't the runtime be initialized early and automatically before any user code is run, e.g. as an early side effect of loading libgerbil ?

@fare fare enabled auto-merge (squash) October 6, 2023 12:07
@fare fare merged commit 324686a into master Oct 6, 2023
11 checks passed
@fare fare deleted the some-fixes branch October 6, 2023 12:52
@vyzo
Copy link
Collaborator Author

vyzo commented Oct 6, 2023

Because libgerbil doesnt know in advance what nodes will be builtin.
And ultimately it shouldn't, the only thing you cannot do without gerbil-runtime-init! is load dynamic modules, and loading them in the initializer of a module is undefined behaviour because the program has not been fully initialized yet.

So yeah, it does the right thing right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants