Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gxpkg: fix bug in installation with diamond dependencies #972

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

vyzo
Copy link
Collaborator

@vyzo vyzo commented Oct 4, 2023

If the package has diamond dependencies, installing the dependency would cause a reverse dependency build, which would fail because the other dependencies are not there.

🤦

If the package has dependencies, installing the dependency would cause
a reverse dependency build, which would fail because the other
dependencies are not there.

:face_palm:
@vyzo vyzo requested a review from a team October 4, 2023 09:30
@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for elastic-ritchie-8f47f9 ready!

Name Link
🔨 Latest commit 50f5c4b
🔍 Latest deploy log https://app.netlify.com/sites/elastic-ritchie-8f47f9/deploys/651d3838dcc9440008b327ab
😎 Deploy Preview https://deploy-preview-972--elastic-ritchie-8f47f9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vyzo vyzo changed the title gxpkg: fix bug in installation with multiple dependencies gxpkg: fix bug in installation with diamond dependencies Oct 4, 2023
@vyzo vyzo enabled auto-merge (squash) October 4, 2023 10:02
@vyzo vyzo merged commit 1d2c0f9 into master Oct 4, 2023
11 checks passed
@vyzo vyzo deleted the fix-gxkpg-multideps branch October 4, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants