Let over using #947
Merged
Let over using #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for elastic-ritchie-8f47f9 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
drewc
approved these changes
Sep 30, 2023
fare
reviewed
Sep 30, 2023
| @@ -60,7 +60,7 @@ | |||
| (mutex-lock! cp.mx) | |||
| (set! cp.out (remq conn cp.out)) | |||
| (mutex-unlock! cp.mx) | |||
| {destroy conn})) | |||
| {conn.destroy})) | |||
There was a problem hiding this comment.
How does that work over {} ?
There was a problem hiding this comment.
I added support for dots in the @method macro in the ptelude in the original using pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we frequently have to write
(let (x expr) (using (x ...)) body ...)and this was too much typing and rightwards drift.This extends the all powerful
usingmacro to support this pattern with(using (var expr ~ contract) body ...).