-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source to build-spec #924
Conversation
✅ Deploy Preview for elastic-ritchie-8f47f9 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/std/source.ss
Outdated
@@ -1,6 +1,7 @@ | |||
(export #t) | |||
|
|||
(import (for-syntax ./stxutil) | |||
./stxutil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uhm, can we avoid this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean exactly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This import is syntax only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ie, it should not be imported in runtime code.
ed9291a
to
03c6a20
Compare
PTAL I had to import a couple into std/misc/path and decided to bring in everything from gerbil-utils/path.ss. The import situation only got worse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the foo
business is necessary, you can just shift the phase and eval-syntax with (parameterize ((current-expander-phi (1+ (current-expander-phi))) (eval-syntax ...))
But it works, funky as it is, so fine by me.
Also import clan/path into std/misc/path.