Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source to build-spec #924

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Add source to build-spec #924

merged 1 commit into from
Sep 26, 2023

Conversation

fare
Copy link
Collaborator

@fare fare commented Sep 25, 2023

Also import clan/path into std/misc/path.

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for elastic-ritchie-8f47f9 ready!

Name Link
🔨 Latest commit 9146599
🔍 Latest deploy log https://app.netlify.com/sites/elastic-ritchie-8f47f9/deploys/6511d04ba9543d0008273518
😎 Deploy Preview https://deploy-preview-924--elastic-ritchie-8f47f9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -1,6 +1,7 @@
(export #t)

(import (for-syntax ./stxutil)
./stxutil
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhm, can we avoid this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean exactly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import is syntax only.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ie, it should not be imported in runtime code.

@fare fare force-pushed the source branch 2 times, most recently from ed9291a to 03c6a20 Compare September 25, 2023 15:59
@fare
Copy link
Collaborator Author

fare commented Sep 25, 2023

PTAL

I had to import a couple into std/misc/path and decided to bring in everything from gerbil-utils/path.ss.

The import situation only got worse.

src/std/source.ss Outdated Show resolved Hide resolved
Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the foo business is necessary, you can just shift the phase and eval-syntax with (parameterize ((current-expander-phi (1+ (current-expander-phi))) (eval-syntax ...))

But it works, funky as it is, so fine by me.

@fare fare merged commit 01d7a9e into master Sep 26, 2023
@fare fare deleted the source branch September 26, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants