Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gxpkg improvements #916

Merged
merged 18 commits into from
Sep 24, 2023
Merged

gxpkg improvements #916

merged 18 commits into from
Sep 24, 2023

Conversation

vyzo
Copy link
Collaborator

@vyzo vyzo commented Sep 23, 2023

Drastically improves gxpkg:

  • Directories:
    • update for the new directory format
    • add mighty-gerbils as the default directory
    • add a dir subcommand to manage the user directory, most notably add new directories saved in {GERBIL_PATH|~/.gerbil}/pkg/directory-list
  • Dependency Management
    • adds a new deps subcommand to manage the dependencies of the current package/project
  • Package Versioning with git tags
    • understands the @tag suffix in packages to mean "a git checkoutable thing"
    • implements (non strict) semver for choice of package when there is a version conflict. This is non strict in the sense that it always chooses the highest version, without putting a minor cap. We have discussed this behaviour with fare, belmarca and feeley and we concluded that it is better to put a subpackage v2 into your package once you are out of v1. Anyhow, I am happy with what we have now, but we can revisit in the future.
  • Package build isolation and build manifests
    • each project is assembled in its own local GERBIL_PATH (unless the user has explicitly set GERBIL_PATH) to avoid interference from dirty ~/.gerbil.
    • each build has a manifest that record the exact dependencies at the time of build.

See #899
See #780
Closes #703
Closes #895
Closes #899

TBD:

@vyzo vyzo requested review from fare, drewc and a team September 23, 2023 19:56
@netlify
Copy link

netlify bot commented Sep 23, 2023

Deploy Preview for elastic-ritchie-8f47f9 ready!

Name Link
🔨 Latest commit fd8a7b5
🔍 Latest deploy log https://app.netlify.com/sites/elastic-ritchie-8f47f9/deploys/65105dfd648c690008f25186
😎 Deploy Preview https://deploy-preview-916--elastic-ritchie-8f47f9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

(else other)))))))

(def +rx-semver+
(pregexp "v(\\d+\\.)*\\d+"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the v?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, semver tags have a v before.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's follow go's convention here, it is good.

src/tools/gxpkg.ss Outdated Show resolved Hide resolved
src/tools/gxpkg.ss Outdated Show resolved Hide resolved
This addresses the global-vs-local state madness with .gerbil:
When we are in local package context, we create a new local .gerbil to
use for the build, which gives us isolation.
We also create manifests for all the individual packages, so that we can
get meaningful error reports.

On top of #916.
See also #651
@vyzo vyzo force-pushed the gxpkg-to-the-future branch from 2896d2f to fd8a7b5 Compare September 24, 2023 16:04
@vyzo vyzo merged commit 7822af0 into master Sep 24, 2023
@vyzo vyzo deleted the gxpkg-to-the-future branch September 24, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants