-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gxpkg improvements #916
gxpkg improvements #916
Conversation
- default is the official mighty-gerbils directory - allow user specified directories to search
✅ Deploy Preview for elastic-ritchie-8f47f9 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
(else other))))))) | ||
|
||
(def +rx-semver+ | ||
(pregexp "v(\\d+\\.)*\\d+")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need the v?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, semver tags have a v before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's follow go's convention here, it is good.
This addresses the global-vs-local state madness with .gerbil: When we are in local package context, we create a new local .gerbil to use for the build, which gives us isolation. We also create manifests for all the individual packages, so that we can get meaningful error reports. On top of #916. See also #651
2896d2f
to
fd8a7b5
Compare
Drastically improves gxpkg:
dir
subcommand to manage the user directory, most notably add new directories saved in{GERBIL_PATH|~/.gerbil}/pkg/directory-list
@tag
suffix in packages to mean "a git checkoutable thing"v2
into your package once you are out of v1. Anyhow, I am happy with what we have now, but we can revisit in the future.~/.gerbil
.See #899
See #780
Closes #703
Closes #895
Closes #899
TBD: