Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: pass on parallelism to build.sh, run configure when required. #884

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

leahneukirchen
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Sep 20, 2023

👷 Deploy request for elastic-ritchie-8f47f9 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 59d1a23

Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

Lets resolve the issue with fresh checkout and it is good to merge.

Makefile Outdated
all: build

build-env.sh:
make clean
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually this might fail one empty checkout, configure fetches the submodule.
So lets remove.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the clean i mean.

Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, lets wait for CI a bit and I will merge on green.

@vyzo
Copy link
Collaborator

vyzo commented Sep 20, 2023

Docker build failure unrelated, it is a bug in the Dockerfile; cc @ober

@vyzo vyzo merged commit 792c1f1 into mighty-gerbils:master Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants