Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many cleanups post JSON RPC #869

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Many cleanups post JSON RPC #869

merged 1 commit into from
Sep 18, 2023

Conversation

fare
Copy link
Collaborator

@fare fare commented Sep 17, 2023

No description provided.

@fare fare requested a review from vyzo September 17, 2023 23:54
@netlify
Copy link

netlify bot commented Sep 17, 2023

Deploy Preview for elastic-ritchie-8f47f9 ready!

Name Link
🔨 Latest commit 1aef68f
🔍 Latest deploy log https://app.netlify.com/sites/elastic-ritchie-8f47f9/deploys/6507e48c65288e0008a35017
😎 Deploy Preview https://deploy-preview-869--elastic-ritchie-8f47f9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fare fare force-pushed the json-rpc-cleanups branch 2 times, most recently from 3ff306c to 2b37d33 Compare September 18, 2023 00:05
Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the method definitions are borked.

Also, in the parsers, (let (reader (Reader reader)) ...) at the top.

src/std/io/port.ss Outdated Show resolved Hide resolved
src/std/text/basic-parsers.ss Outdated Show resolved Hide resolved
src/std/text/basic-parsers.ss Outdated Show resolved Hide resolved
@fare fare force-pushed the json-rpc-cleanups branch from 2b37d33 to b3c4038 Compare September 18, 2023 00:51
@fare fare force-pushed the json-rpc-cleanups branch 4 times, most recently from 4678b55 to bb6d0de Compare September 18, 2023 04:59
@fare fare force-pushed the json-rpc-cleanups branch from bb6d0de to 1aef68f Compare September 18, 2023 05:47
@fare fare merged commit 318e99d into master Sep 18, 2023
@fare fare deleted the json-rpc-cleanups branch September 18, 2023 07:36
@vyzo vyzo mentioned this pull request Sep 18, 2023
2 tasks
@vyzo vyzo added this to the Gerbil v0.18: Nimzowitsch milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants