Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add makefile gxpkg new #856

Merged
merged 7 commits into from
Sep 15, 2023
Merged

Add makefile gxpkg new #856

merged 7 commits into from
Sep 15, 2023

Conversation

ober
Copy link
Collaborator

@ober ober commented Sep 15, 2023

No description provided.

vyzo
vyzo reviewed Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some suggested improvements.

src/tools/gxpkg.ss Outdated Show resolved Hide resolved
src/tools/gxpkg.ss Outdated Show resolved Hide resolved
vyzo
vyzo reviewed Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add a clean rule

vyzo
vyzo approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the docker build segfaults with Illegal Instruction.

This is probably a container issue, so this pr is ready from my point of view.

@ober ober merged commit 621c577 into master Sep 15, 2023
@ober ober deleted the add-makefile-gxpkg-new branch September 15, 2023 18:23
@vyzo vyzo added this to the Gerbil v0.18: Nimzowitsch milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gerbil v0.18: Nimzowitsch
Development

Successfully merging this pull request may close these issues.
2 participants
@ober @vyzo