Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configure and Makefile #756

Merged
merged 3 commits into from
Aug 6, 2023
Merged

Fix configure and Makefile #756

merged 3 commits into from
Aug 6, 2023

Conversation

vyzo
Copy link
Collaborator

@vyzo vyzo commented Aug 6, 2023

The thing was flat out broken; instead of installing under prefix it installed under prefix/gerbi/something and linked the binaries. This is the wrong thing to do: when the user says prefix he means prefix, not some random directory underneath.

@vyzo vyzo requested review from ober and drewc August 6, 2023 19:39
@vyzo vyzo changed the title Fix configure Fix configure and Makefile Aug 6, 2023
@ober
Copy link
Collaborator

ober commented Aug 6, 2023

tested in docker. all works as expected.

Copy link
Collaborator

@ober ober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

@vyzo vyzo merged commit 7fd4a28 into master Aug 6, 2023
@vyzo vyzo deleted the fix-configure branch August 6, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants