-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous fixes #734
Merged
Merged
Miscellaneous fixes #734
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
580d854
std/event: simplify wait-for-io
vyzo c0f6b37
gerbil/gaambit/threads: with-lock without dynamic-wind
vyzo 3626cc1
std/interface: improved ergonomics
vyzo 6738b50
std/make: fix bug, add verbosity envvar
vyzo 9340926
std/os/socket: misc fixes
vyzo 58a743f
httpd-test: use a less common port
vyzo 91e112a
improve with-lock's tolerance to nested exceptions.
vyzo e76fd31
fix #669
vyzo 1d2917b
std/event: fix handling of timeouts in wait-io
vyzo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The for-each sounds very wrong and contrary to the principles of make: make a queue of things to be scheduled according to dependency order, rather than execute immediately out of a plan (which can lead to out-of-dependency-order execution, lack of parallelism, and/or sometimes double execution).
If things are not currently done, they need to be queued as dependencies, not done immediately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but the code right now is completely broken; submodules never get built.
If you can suggest a better fix, fine, but iam inclined to keep it as is (and i dont fully understand the code the way it has morphed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, after conversation with vyzo, it looks like the ssi entry also uses for-each build, and that I had just forgotten the same thing for gxc: after patiently building it in normalize-buildspec, so it doesn't look that wrong after all.
This part of the code is very much out-of-cache for me right now, and obviously under-documented. But the fix now looks right-ish. I will have to make another pass at documenting things whenever I put things back into cache.