make ./configure autoset gcc via CC & friends #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for elastic-ritchie-8f47f9 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vyzo
reviewed
Apr 17, 2024
drewc
changed the title
|
I really don't like the modifying a source file in-place. It doesn't play well with git. Generating a different file, or having the file read some configuration at compile-time, would be much better. |
|
👍 |
vyzo
requested changes
Aug 5, 2024
| @@ -47,6 +47,34 @@ EOF | |||
| } | |||
|
|
|||
|
|
|||
| set_gerbil_gcc () { | |||
| echo "\n;; Added auto via ./configure\n(set! %default-gerbil-gcc \"$1\")" >> \ | |||
| ./src/gerbil/compiler/driver.ss | |||
There was a problem hiding this comment.
Please don't. It is not acceptible to modify any module of the compiler -- that's bad juju.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
%default-gerbil-gcccan be set! semi-permanently via the./configurescript by$CCor$GERBIL_GCC.Then the gxc compiler (and bach) will always use that UNLESS it no longer exists or
GERBIL_GCCis set, orCCis set.If it cannot find them the old "use the first gcc in $PATH" applies. This is exported via
(gerbil-gcc)A config file will be added.