defmutable-rules: identifier-rules variant of defmutable #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for elastic-ritchie-8f47f9 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Merged
fare
reviewed
Apr 15, 2024
There was a problem hiding this comment.
- Shouldn't we rename defmutable-rules to defmutable and be done?
- All the use sites of "defmutable" assume the old API which I suspect is the API of defmutable-rules and NOT that of the current defmutable
- If the problem is telling the type inferencer about the out-of-module set! --- why not add a new kind of annotation just for that, instead of doing weird things in identifier-rules?
|
|
Updated, as discussed. |
and the artist formerly known as defmutable, is defmutable*
fare
requested changes
Apr 18, 2024
| @@ -13,7 +13,7 @@ namespace: #f | |||
| [["Gerbil" :: (gerbil-version-string)] | |||
| ["Gambit" :: (system-version-string)]]) | |||
|
|
|||
| (defmutable build-manifest gerbil-system-manifest : :list) | |||
| (defmutable* build-manifest gerbil-system-manifest : :list) | |||
There was a problem hiding this comment.
Why use defmutable* rather than defmutable?
And if so, you must update std/cli/multicall.ss (as found with git grep build-manifest).
There was a problem hiding this comment.
we cannot export macros from the runtime through the prelude interface, as I have explained to you.
| @@ -45,7 +45,7 @@ namespace: #f | |||
| => :string | |||
| (build-manifest-string gerbil-system-manifest)) | |||
|
|
|||
| (defmutable gerbil-greeting (gerbil-system-version-string) : :string) | |||
| (defmutable* gerbil-greeting (gerbil-system-version-string) : :string) | |||
There was a problem hiding this comment.
Same question.
Need to update gerbil/boot-gxi.c, gerbil/interactive/init.ss.
There was a problem hiding this comment.
You still need to update gerbil/boot-gxi.c
|
OK, but then you need to update the places that use the variables that used to be defmutable and are now defmutable* |
|
done. |
fare
approved these changes
Apr 20, 2024
|
done. |
vyzo
added a commit
that referenced
this pull request
Apr 20, 2024
Let's have types there too. Also improves match code generation a tad. On top of #1220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't use it in the runtime due to the public exports, but it is probably more of what you want in userland.