Improve Text Chapters / YouTube import #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Why did you close this? I think it could be a useful improvement |
|
Hi there! Thanks for the response. I closed it because I wasn't sure it fixed #1642 without causing any feature regressions, since I don't have the experience with testing or regex to make this change with confidence. It might work better as a draft PR, but I need some help with review and also the second description type that I added to the issue, which I think would require a more complex solution with timecodes out of order. I've edited the PR to match its status better, thanks for the nudge! |
thatrobotdev
changed the title
|
I appreciate you for reviewing and adding tests, thank you so much! :) |
|
Of course! thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts fixing #1642, and allows timestamps with semicolons directly after them like
0:00: JDX - Tides (Trailerized)to be imported.I have tested it with the two descriptions in #1642, but I'm not sure if this would unexpectedly break the regex or if there is a better way to do it.