Speed up NextLabel and PrevLabel #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces readability, but they are in the hot path of coredns.
Codecov Report
@@ Coverage Diff @@
## master #1039 +/- ##
=========================================
+ Coverage 54.92% 55% +0.07%
=========================================
Files 41 41
Lines 9869 9879 +10
=========================================
+ Hits 5421 5434 +13
+ Misses 3425 3423 -2
+ Partials 1023 1022 -1
Continue to review full report at Codecov.
|
tmthrgd
approved these changes
Nov 30, 2019
tmthrgd
reviewed
Dec 1, 2019
|
thank you both |
aanm
pushed a commit
to cilium/dns
that referenced
this pull request
Jul 29, 2022
* change NextLabel and PrevLabel to be faster This reduces readability, but they are in the hot path of coredns. * @redyeti pointed out, that my implementation disregarded triple backslashes * add synthetic benchmark-tests for PrevLabel and NextLabel * rename ii -> j * invert compare * PrevLabel: add empty string check + test case * NextLabel: fix and add testcase for NextLabel("", offset>0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NextLabel and PrevLabel are heavily used in the "file" plugin in coredns. This change introduces benchmark tests and improves the performance (on my machine).
It eliminates all allocations and uses strings in a way that should make L1-Cache-Hits more likely.
The time for coredns "file"-plugin Requests is cut roughly in half.