Merge pull request #1254 from naorpeled/feat/pkgs/http-security-heade…

…rs/support-report-only-mode feat(http-security-headers): support report only mode
middyjs · Oct 26, 2024 · 38e121a · 38e121a
2 parents 01e049b + 2c50f33
commit 38e121a
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 4 deletions.
diff --git a/packages/http-security-headers/__tests__/index.js b/packages/http-security-headers/__tests__/index.js
@@ -268,3 +268,28 @@ test('It should apply security headers if error is handled', async (t) => {
   equal(response.headers['X-Frame-Options'], undefined)
   equal(response.headers['X-XSS-Protection'], undefined)
 })
+
+test('It should support report only mode', async (t) => {
+  const handler = middy(() => createHtmlObjectResponse())
+
+  handler.use(
+    httpSecurityHeaders({
+      contentSecurityPolicy: {
+        reportOnly: true
+      }
+    })
+  )
+
+  const event = {
+    httpMethod: 'GET'
+  }
+
+  const response = await handler(event, defaultContext)
+
+  equal(response.statusCode, 200)
+  equal(response.headers['Content-Security-Policy'], undefined)
+  equal(
+    response.headers['Content-Security-Policy-Report-Only'],
+    "default-src 'none'; base-uri 'none'; form-action 'none'; frame-ancestors 'none'; navigate-to 'none'; report-to csp; require-trusted-types-for 'script'; trusted-types 'none'; sandbox; upgrade-insecure-requests"
+  )
+})
diff --git a/packages/http-security-headers/index.d.ts b/packages/http-security-headers/index.d.ts
@@ -28,7 +28,7 @@ interface Options {
   xssProtection?: {
     reportUri?: string
   }
-  contentSecurityPolicy?: Record<string, string>
+  contentSecurityPolicy?: Record<string, string | boolean>
   crossOriginEmbedderPolicy?: {
     policy?: string
   }

diff --git a/packages/http-security-headers/index.js b/packages/http-security-headers/index.js
@@ -34,7 +34,8 @@ const defaults = {
     // Other directives
     'require-trusted-types-for': "'script'",
     'trusted-types': "'none'",
-    'upgrade-insecure-requests': ''
+    'upgrade-insecure-requests': '',
+    reportOnly: false
   },
   contentTypeOptions: {
     action: 'nosniff'
@@ -138,6 +139,7 @@ const helmetHtmlOnly = {}
 // https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy
 helmetHtmlOnly.contentSecurityPolicy = (headers, config) => {
   let header = Object.keys(config)
+    .filter((policy) => policy !== 'reportOnly')
     .map((policy) => (config[policy] ? `${policy} ${config[policy]}` : ''))
     .filter((str) => str)
     .join('; ')
@@ -147,7 +149,11 @@ helmetHtmlOnly.contentSecurityPolicy = (headers, config) => {
   if (config['upgrade-insecure-requests'] === '') {
     header += '; upgrade-insecure-requests'
   }
-  headers['Content-Security-Policy'] = header
+
+  const cspHeaderName = config.reportOnly
+    ? 'Content-Security-Policy-Report-Only'
+    : 'Content-Security-Policy'
+  headers[cspHeaderName] = header
 }
 // crossdomain - N/A - for Adobe products
 helmetHtmlOnly.crossOriginEmbedderPolicy = (headers, config) => {

diff --git a/packages/http-security-headers/index.test-d.ts b/packages/http-security-headers/index.test-d.ts
@@ -37,7 +37,8 @@ middleware = httpSecurityHeaders({
   },
   contentSecurityPolicy: {
     'default-src': "'none'",
-    sandbox: ''
+    sandbox: '',
+    reportOnly: true
   },
   crossOriginEmbedderPolicy: {
     policy: 'require-corp'