chore: clean up

middyjs · Dec 10, 2023 · 058181a · 058181a
1 parent dd8d9ce
commit 058181a
Show file tree

Hide file tree

Showing 21 changed files with 60 additions and 40 deletions.
diff --git a/packages/appconfig/__benchmarks__/index.js b/packages/appconfig/__benchmarks__/index.js
@@ -48,13 +48,14 @@ const setupHandler = (options = {}) => {
 const coldHandler = setupHandler({ cacheExpiry: 0 })
 const warmHandler = setupHandler()
 
+const event = {}
 await bench
-  .add('without cache', async (event = {}) => {
+  .add('without cache', async () => {
     try {
       await coldHandler(event, context)
     } catch (e) {}
   })
-  .add('with cache', async (event = {}) => {
+  .add('with cache', async () => {
     try {
       await warmHandler(event, context)
     } catch (e) {}

diff --git a/packages/cloudwatch-metrics/__benchmarks__/index.js b/packages/cloudwatch-metrics/__benchmarks__/index.js
@@ -15,13 +15,14 @@ const setupHandler = (options = {}) => {
 const coldHandler = setupHandler({ cacheExpiry: 0 })
 const warmHandler = setupHandler()
 
+const event = {}
 await bench
-  .add('without cache', async (event = {}) => {
+  .add('without cache', async () => {
     try {
       await coldHandler(event, context)
     } catch (e) {}
   })
-  .add('with cache', async (event = {}) => {
+  .add('with cache', async () => {
     try {
       await warmHandler(event, context)
     } catch (e) {}

diff --git a/packages/core/__benchmarks__/index.js b/packages/core/__benchmarks__/index.js
@@ -76,7 +76,7 @@ await bench
   .add('Warm Invocation', async () => {
     await warmHandler(event, context)
   })
-  // .add('Warm Invocation * next', async (event = {}) => {
+  // .add('Warm Invocation * next', async () => {
   //   await warmNextHandler(event, context)
   // })
   .add('Warm Async Invocation', async () => {
@@ -85,14 +85,14 @@ await bench
   .add('Warm Invocation with disabled Timeout', async () => {
     await warmDisableTimeoutHandler(event, context)
   })
-  // .add('Warm Invocation with disabled Timeout * next', async (event = {}) => {
+  // .add('Warm Invocation with disabled Timeout * next', async () => {
   //   await warmNextTimeoutHandler(event, context)
   // })
   // TODO StreamifyResponse
   .add('Warm Invocation with middleware', async () => {
     await warmMiddlewareHandler(event, context)
   })
-  // .add('Warm Invocation with middleware * next', async (event = {}) => {
+  // .add('Warm Invocation with middleware * next', async () => {
   //   await warmNextMiddlewareHandler(event, context)
   // })
   .add('Warm Invocation with async middleware', async () => {

diff --git a/packages/do-not-wait-for-empty-event-loop/__benchmarks__/index.js b/packages/do-not-wait-for-empty-event-loop/__benchmarks__/index.js
@@ -14,8 +14,9 @@ const setupHandler = () => {
 
 const warmHandler = setupHandler()
 
+const event = {}
 await bench
-  .add('Change Context', async (event = {}) => {
+  .add('Change Context', async () => {
     try {
       await warmHandler(event, context)
     } catch (e) {}

diff --git a/packages/dynamodb/__benchmarks__/index.js b/packages/dynamodb/__benchmarks__/index.js
@@ -32,13 +32,14 @@ const setupHandler = (options = {}) => {
 const coldHandler = setupHandler({ cacheExpiry: 0 })
 const warmHandler = setupHandler()
 
+const event = {}
 await bench
-  .add('without cache', async (event = {}) => {
+  .add('without cache', async () => {
     try {
       await coldHandler(event, context)
     } catch (e) {}
   })
-  .add('with cache', async (event = {}) => {
+  .add('with cache', async () => {
     try {
       await warmHandler(event, context)
     } catch (e) {}

diff --git a/packages/error-logger/__benchmarks__/index.js b/packages/error-logger/__benchmarks__/index.js
@@ -16,8 +16,9 @@ const setupHandler = () => {
 
 const warmHandler = setupHandler()
 
+const event = {}
 await bench
-  .add('Catch Error', async (event = {}) => {
+  .add('Catch Error', async () => {
     try {
       await warmHandler(event, context)
     } catch (e) {}

diff --git a/packages/http-content-encoding/__benchmarks__/index.js b/packages/http-content-encoding/__benchmarks__/index.js
@@ -17,13 +17,14 @@ const setupHandler = (options) => {
 const gzHandler = setupHandler({ preferredEncoding: 'gz' })
 const brHandler = setupHandler({ preferredEncoding: 'br' })
 
+const event = {}
 await bench
-  .add('gzip Response', async (event = {}) => {
+  .add('gzip Response', async () => {
     try {
       await gzHandler(event, context)
     } catch (e) {}
   })
-  .add('brotli Response', async (event = {}) => {
+  .add('brotli Response', async () => {
     try {
       await brHandler(event, context)
     } catch (e) {}

diff --git a/packages/http-error-handler/__benchmarks__/index.js b/packages/http-error-handler/__benchmarks__/index.js
@@ -16,8 +16,9 @@ const setupHandler = () => {
 
 const warmHandler = setupHandler()
 
+const event = {}
 await bench
-  .add('Handle Error', async (event = {}) => {
+  .add('Handle Error', async () => {
     try {
       await warmHandler(event, context)
     } catch (e) {}

diff --git a/packages/http-event-normalizer/__benchmarks__/index.js b/packages/http-event-normalizer/__benchmarks__/index.js
@@ -14,8 +14,9 @@ const setupHandler = () => {
 
 const warmHandler = setupHandler()
 
+const event = {}
 await bench
-  .add('Normalize Event', async (event = {}) => {
+  .add('Normalize Event', async () => {
     try {
       await warmHandler(event, context)
     } catch (e) {}

diff --git a/packages/http-response-serializer/__benchmarks__/index.js b/packages/http-response-serializer/__benchmarks__/index.js
@@ -37,8 +37,9 @@ const setupHandler = () => {
 
 const warmHandler = setupHandler()
 
+const event = {}
 await bench
-  .add('Serialize Response', async (event = {}) => {
+  .add('Serialize Response', async () => {
     try {
       await warmHandler(event, context)
     } catch (e) {}

diff --git a/packages/http-security-headers/__benchmarks__/index.js b/packages/http-security-headers/__benchmarks__/index.js
@@ -14,8 +14,9 @@ const setupHandler = () => {
 
 const warmHandler = setupHandler()
 
+const event = {}
 await bench
-  .add('Add Headers', async (event = {}) => {
+  .add('Add Headers', async () => {
     try {
       await warmHandler(event, context)
     } catch (e) {}

diff --git a/packages/rds-signer/__benchmarks__/index.js b/packages/rds-signer/__benchmarks__/index.js
@@ -29,13 +29,14 @@ const setupHandler = (options = {}) => {
 const coldHandler = setupHandler({ cacheExpiry: 0 })
 const warmHandler = setupHandler()
 
+const event = {}
 await bench
-  .add('without cache', async (event = {}) => {
+  .add('without cache', async () => {
     try {
       await coldHandler(event, context)
     } catch (e) {}
   })
-  .add('with cache', async (event = {}) => {
+  .add('with cache', async () => {
     try {
       await warmHandler(event, context)
     } catch (e) {}

diff --git a/packages/s3/__benchmarks__/index.js b/packages/s3/__benchmarks__/index.js
@@ -34,13 +34,14 @@ const setupHandler = (options = {}) => {
 const coldHandler = setupHandler({ cacheExpiry: 0 })
 const warmHandler = setupHandler()
 
+const event = {}
 await bench
-  .add('without cache', async (event = {}) => {
+  .add('without cache', async () => {
     try {
       await coldHandler(event, context)
     } catch (e) {}
   })
-  .add('with cache', async (event = {}) => {
+  .add('with cache', async () => {
     try {
       await warmHandler(event, context)
     } catch (e) {}

diff --git a/packages/secrets-manager/__benchmarks__/index.js b/packages/secrets-manager/__benchmarks__/index.js
@@ -29,13 +29,14 @@ const setupHandler = (options = {}) => {
 const coldHandler = setupHandler({ cacheExpiry: 0 })
 const warmHandler = setupHandler()
 
+const event = {}
 await bench
-  .add('without cache', async (event = {}) => {
+  .add('without cache', async () => {
     try {
       await coldHandler(event, context)
     } catch (e) {}
   })
-  .add('with cache', async (event = {}) => {
+  .add('with cache', async () => {
     try {
       await warmHandler(event, context)
     } catch (e) {}

diff --git a/packages/service-discovery/__benchmarks__/index.js b/packages/service-discovery/__benchmarks__/index.js
@@ -42,13 +42,14 @@ const setupHandler = (options = {}) => {
 const coldHandler = setupHandler({ cacheExpiry: 0 })
 const warmHandler = setupHandler()
 
+const event = {}
 await bench
-  .add('without cache', async (event = {}) => {
+  .add('without cache', async () => {
     try {
       await coldHandler(event, context)
     } catch (e) {}
   })
-  .add('with cache', async (event = {}) => {
+  .add('with cache', async () => {
     try {
       await warmHandler(event, context)
     } catch (e) {}

diff --git a/packages/sqs-partial-batch-failure/__benchmarks__/index.js b/packages/sqs-partial-batch-failure/__benchmarks__/index.js
@@ -9,8 +9,8 @@ const context = {
 }
 const setupHandler = () => {
   const baseHandler = (event) => {
-    const recordPromises = event.Records.map(async (record, index) => {
-      return record
+    const recordPromises = event.Records.map((record, index) => {
+      return Promise.resolve(record)
     })
     return Promise.allSettled(recordPromises)
   }
@@ -19,13 +19,15 @@ const setupHandler = () => {
 
 const warmHandler = setupHandler()
 
+const event = {
+  Records: [{}]
+}
 await bench
-  .add('process failures', async (event = {}) => {
+  .add('process failures', async () => {
     try {
       await warmHandler(event, context)
     } catch (e) {}
   })
-
   .run()
 
 console.table(bench.table())
diff --git a/packages/ssm/__benchmarks__/index.js b/packages/ssm/__benchmarks__/index.js
@@ -32,13 +32,14 @@ const setupHandler = (options = {}) => {
 const coldHandler = setupHandler({ cacheExpiry: 0 })
 const warmHandler = setupHandler()
 
+const event = {}
 await bench
-  .add('without cache', async (event = {}) => {
+  .add('without cache', async () => {
     try {
       await coldHandler(event, context)
     } catch (e) {}
   })
-  .add('with cache', async (event = {}) => {
+  .add('with cache', async () => {
     try {
       await warmHandler(event, context)
     } catch (e) {}

diff --git a/packages/sts/__benchmarks__/index.js b/packages/sts/__benchmarks__/index.js
@@ -32,13 +32,14 @@ const setupHandler = (options = {}) => {
 const coldHandler = setupHandler({ cacheExpiry: 0 })
 const warmHandler = setupHandler()
 
+const event = {}
 await bench
-  .add('without cache', async (event = {}) => {
+  .add('without cache', async () => {
     try {
       await coldHandler(event, context)
     } catch (e) {}
   })
-  .add('with cache', async (event = {}) => {
+  .add('with cache', async () => {
     try {
       await warmHandler(event, context)
     } catch (e) {}

diff --git a/packages/util/__benchmarks__/index.js b/packages/util/__benchmarks__/index.js
@@ -10,20 +10,20 @@ import {
 const bench = new Bench({ time: 1_000 })
 
 await bench
-  .add('getInternal', async (event = {}) => {
+  .add('getInternal', async () => {
     await getInternal(true, {
       internal: {
         key: Promise.resolve('value')
       }
     })
   })
-  .add('processCache', async (event = {}) => {
+  .add('processCache', async () => {
     await processCache({ cacheExpiry: -1, cacheKey: 'key' })
   })
-  .add('jsonSafeParse', async (event = {}) => {
+  .add('jsonSafeParse', async () => {
     await jsonSafeParse('{"key":"value"}')
   })
-  .add('normalizeHttpResponse', async (event = {}) => {
+  .add('normalizeHttpResponse', async () => {
     await normalizeHttpResponse({})
   })
 

diff --git a/packages/validator/__benchmarks__/index.js b/packages/validator/__benchmarks__/index.js
@@ -20,8 +20,9 @@ const setupHandler = () => {
 
 const warmHandler = setupHandler()
 
+const event = {}
 await bench
-  .add('type check input & output', async (event = {}) => {
+  .add('type check input & output', async () => {
     try {
       await warmHandler(event, context)
     } catch (e) {}

diff --git a/packages/ws-response/__benchmarks__/index.js b/packages/ws-response/__benchmarks__/index.js
@@ -29,13 +29,14 @@ const setupHandler = (options = {}) => {
 const coldHandler = setupHandler({ cacheExpiry: 0 })
 const warmHandler = setupHandler()
 
+const event = {}
 await bench
-  .add('without cache', async (event = {}) => {
+  .add('without cache', async () => {
     try {
       await coldHandler(event, context)
     } catch (e) {}
   })
-  .add('with cache', async (event = {}) => {
+  .add('with cache', async () => {
     try {
       await warmHandler(event, context)
     } catch (e) {}