Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded Next.js to 15.0.1 #614

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Conversation

Reterics
Copy link
Contributor

Linked Issue(s)

Fixes #597

Acceptance Criteria fulfillment

Viewed/Tested pages:

  • /teams
    • Add, remove, edit teams
  • /dora-metrics
    • Settings -> Configure Production branches popup
    • Pull Request Insights
    • Calendar date changing
  • /integrations
    • Removed Token, configured again
  • /settings
  • /system-logs
  • Opened Help Assistant

Proposed changes (including videos or screenshots)

According to the article on https://nextjs.org/blog/next-15, Next.js 15 is officially stable and ready for production, so I made 2 commits in this PR: (Reason: in case if we need Next.js 14 instead)

  1. I updated to version 14, and did my testcases above
  2. and then updated to 15 and did them again.

image

Further comments

UI related warnings were there before the update as well such as: (There were not introduced in this PR)

  • "CreateTeams.tsx:259 Warning: A props object containing a "key" prop is being spread into JSX:"
  • "DeploymentInsightsOverlay.tsx:364 Warning: Each child in a list should have a unique "key" prop."

@Reterics Reterics changed the title fix: updated Next to 14.2.16 Upgraded Next.js to 15.0.1 Oct 26, 2024
@jayantbh
Copy link
Contributor

Well, that's a bigger PR than I was expecting. 😄
Let's get this merged before hacktoberfest ends! 👌🏽 🚀

Copy link
Contributor

@jayantbh jayantbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly the change I'm requesting at the moment isn't even worth blocking the PR over, except that the contributing guide changed significantly and this might need to weird confusions if this were to be merged as is.

Also surprised that there's not bigger breakages or type changes. We'll check this PR locally once.

.github/workflows/pre-commit.yml Show resolved Hide resolved
@jayantbh
Copy link
Contributor

Type checking doesn't seem to work via the CLI, but I suspect it isn't actually related to this PR.

➜  web-server git:(feat/next-upgrade) yarn tsc                                                      
yarn run v1.22.22
$ /Users/jayant/Projects/dora-metrics/web-server/node_modules/.bin/tsc
/Users/jayant/Projects/dora-metrics/web-server/node_modules/typescript/lib/tsc.js:116479
      throw e;
      ^

RangeError: Map maximum size exceeded
    at Map.set (<anonymous>)
    at recursiveTypeRelatedTo (/Users/jayant/Projects/dora-metrics/web-server/node_modules/typescript/lib/tsc.js:60782:18)
    at isRelatedTo (/Users/jayant/Projects/dora-metrics/web-server/node_modules/typescript/lib/tsc.js:60199:122)
    at checkTypeRelatedTo (/Users/jayant/Projects/dora-metrics/web-server/node_modules/typescript/lib/tsc.js:59834:20)
    at isTypeRelatedTo (/Users/jayant/Projects/dora-metrics/web-server/node_modules/typescript/lib/tsc.js:59778:14)
    at isTypeAssignableTo (/Users/jayant/Projects/dora-metrics/web-server/node_modules/typescript/lib/tsc.js:58892:12)
    at typeMaybeAssignableTo (/Users/jayant/Projects/dora-metrics/web-server/node_modules/typescript/lib/tsc.js:64446:11)
    at /Users/jayant/Projects/dora-metrics/web-server/node_modules/typescript/lib/tsc.js:64463:58
    at filter (/Users/jayant/Projects/dora-metrics/web-server/node_modules/typescript/lib/tsc.js:169:23)
    at filterType (/Users/jayant/Projects/dora-metrics/web-server/node_modules/typescript/lib/tsc.js:64752:24)

Node.js v22.10.0
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@jayantbh
Copy link
Contributor

Okay, the issue I mentioned above is now fixed in main. Please rebase, address the super trivial comment left, and I think we're good.

@Reterics Reterics force-pushed the feat/next-upgrade branch 2 times, most recently from 263e179 to 1d55b2e Compare October 28, 2024 16:26
@Reterics
Copy link
Contributor Author

Okay, the issue I mentioned above is now fixed in main. Please rebase, address the super trivial comment left, and I think we're good.

After rebase i verified with "yarn tsc " you mentioned above. It is working. Hopefully it will be fine now.

@Reterics Reterics requested a review from jayantbh October 28, 2024 16:28
@jayantbh
Copy link
Contributor

Just confirming, did yarn tsc in the web-server module work fine for you?

@Reterics
Copy link
Contributor Author

Just confirming, did yarn tsc in the web-server module work fine for you?

Yes it is working fine. (both Ubuntu and Windows 11)
image

image

@jayantbh
Copy link
Contributor

Great stuff, @Reterics!
Thank you!

@jayantbh jayantbh merged commit 2b7ec16 into middlewarehq:main Oct 30, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Next.js 14+
2 participants