-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded Next.js to 15.0.1 #614
Conversation
Well, that's a bigger PR than I was expecting. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly the change I'm requesting at the moment isn't even worth blocking the PR over, except that the contributing guide changed significantly and this might need to weird confusions if this were to be merged as is.
Also surprised that there's not bigger breakages or type changes. We'll check this PR locally once.
Type checking doesn't seem to work via the CLI, but I suspect it isn't actually related to this PR.
|
Okay, the issue I mentioned above is now fixed in main. Please rebase, address the super trivial comment left, and I think we're good. |
263e179
to
1d55b2e
Compare
After rebase i verified with "yarn tsc " you mentioned above. It is working. Hopefully it will be fine now. |
Just confirming, did |
Great stuff, @Reterics! |
Linked Issue(s)
Fixes #597
Acceptance Criteria fulfillment
Viewed/Tested pages:
Proposed changes (including videos or screenshots)
According to the article on https://nextjs.org/blog/next-15, Next.js 15 is officially stable and ready for production, so I made 2 commits in this PR: (Reason: in case if we need Next.js 14 instead)
Further comments
UI related warnings were there before the update as well such as: (There were not introduced in this PR)