fixed: change quotes rule from error to warn and applied linting acro…

…ss codebase#600

fix: change quotes rule from error to warn and apply linting across codebase-#600

.vscode/settings.json

@@ -0,0 +1,12 @@
+{
+  "eslint.workingDirectories": [
+    { "directory": "./cli", "changeProcessCWD": true },
+    { "directory": "./web-server", "changeProcessCWD": true }
+  ],
+  "eslint.run": "onSave",
+  "eslint.lintTask.enable": true,
+  "editor.codeActionsOnSave": {
+    "source.fixAll.eslint": "always"
+  },
+  "editor.formatOnSave": false
+}

cli/.eslintrc.cjs

@@ -27,6 +27,11 @@ module.exports = {
     }
   },
   rules: {
+    quotes: [
+      'warn',
+      'single',
+      { avoidEscape: true, allowTemplateLiterals: true }
+    ],
     'no-unsafe-optional-chaining': [
       'error',
       { disallowArithmeticOperators: true }

cli/.vscode/extensions.json

@@ -1,6 +1,3 @@
 {
-  "recommendations": [
-    "gruntfuggly.todo-tree",
-    "stringham.copy-with-imports"
-  ]
+  "recommendations": ["gruntfuggly.todo-tree", "stringham.copy-with-imports"]
 }

cli/.vscode/launch.json

@@ -6,6 +6,6 @@
       "type": "node-terminal",
       "request": "launch",
       "command": "yarn dev"
-    },
+    }
   ]
 }

cli/.vscode/settings.json

@@ -1,12 +1,14 @@
 {
   "workbench.editor.labelFormat": "short",
   "editor.codeActionsOnSave": {
-    "source.fixAll.eslint": "explicit"
+    "source.fixAll.eslint": "always"
   },
+  "editor.formatOnSave": false,
+  "eslint.workingDirectories": [{ "mode": "auto" }],
   "tsEssentialPlugins.autoImport.changeSorting": {
     "createContext": ["react"]
   },
   "tsEssentialPlugins.patchOutline": true,
   "editor.linkedEditing": true,
-  "tsEssentialPlugins.enableMethodSnippets": false,
+  "tsEssentialPlugins.enableMethodSnippets": false
 }

cli/libdefs/ink.ts

@@ -1,7 +1,7 @@
 import 'ink-testing-library';
 
-import {ReactNode} from 'react';
+import { ReactNode } from 'react';
 
 declare module 'ink-testing-library' {
-	export function render(tree: ReactNode): RenderResponse;
+  export function render(tree: ReactNode): RenderResponse;
 }

cli/package.json

@@ -1,63 +1,63 @@
 {
-	"name": "cli",
-	"version": "0.0.0",
-	"license": "MIT",
-	"bin": "dist/cli.js",
-	"engines": {
-		"node": "^22.x"
-	},
-	"type": "module",
-	"scripts": {
-		"build": "tsc",
-		"dev": "tsc --watch",
-		"test": "yarn link-fix && ava",
-		"lint": "eslint source/**/*.{js,ts,tsx}",
-		"lint-fix": "eslint --fix --ignore-pattern 'node_modules/*' 'source/**/*.{js,ts,tsx}'",
-		"start": "[ -e ../.env ] && set -a && . ../.env; node dist/cli.js"
-	},
-	"files": [
-		"dist"
-	],
-	"dependencies": {
-		"@reduxjs/toolkit": "^2.2.3",
-		"dockerode": "^4.0.2",
-		"dockerode-compose": "^1.4.0",
-		"find-free-ports": "^3.1.1",
-		"ink": "^4.4.1",
-		"ink-spinner": "^5.0.0",
-		"meow": "^11.0.0",
-		"ramda": "^0.29.1",
-		"react": "^18.2.0",
-		"react-redux": "^9.1.1"
-	},
-	"devDependencies": {
-		"@types/dockerode": "^3.3.28",
-		"@types/dockerode-compose": "^1.4.1",
-		"@types/ink-testing-library": "^1.0.4",
-		"@types/ramda": "^0.29.12",
-		"@types/react": "^18.0.32",
-		"@typescript-eslint/eslint-plugin": "^6.10.0",
-		"@typescript-eslint/parser": "^6.10.0",
-		"ava": "^5.2.0",
-		"chalk": "^5.2.0",
-		"eslint": "^8.40.0",
-		"eslint-plugin-import": "^2.29.0",
-		"eslint-plugin-prettier": "^5.0.1",
-		"eslint-plugin-react": "^7.32.2",
-		"eslint-plugin-react-hooks": "^4.6.0",
-		"eslint-plugin-unused-imports": "^3.1.0",
-		"ink-testing-library": "^3.0.0",
-		"prettier": "^3.0.3",
-		"ts-node": "^10.9.1",
-		"typescript": "5.3.3"
-	},
-	"ava": {
-		"extensions": {
-			"ts": "module",
-			"tsx": "module"
-		},
-		"nodeArguments": [
-			"--loader=ts-node/esm"
-		]
-	}
+  "name": "cli",
+  "version": "0.0.0",
+  "license": "MIT",
+  "bin": "dist/cli.js",
+  "engines": {
+    "node": "^22.x"
+  },
+  "type": "module",
+  "scripts": {
+    "build": "tsc",
+    "dev": "tsc --watch",
+    "test": "yarn link-fix && ava",
+    "lint": "eslint source/**/*.{js,ts,tsx}",
+    "lint-fix": "eslint --fix --ignore-pattern 'node_modules/*' 'source/**/*.{js,ts,tsx}'",
+    "start": "[ -e ../.env ] && set -a && . ../.env; node dist/cli.js"
+  },
+  "files": [
+    "dist"
+  ],
+  "dependencies": {
+    "@reduxjs/toolkit": "^2.2.3",
+    "dockerode": "^4.0.2",
+    "dockerode-compose": "^1.4.0",
+    "find-free-ports": "^3.1.1",
+    "ink": "^4.4.1",
+    "ink-spinner": "^5.0.0",
+    "meow": "^11.0.0",
+    "ramda": "^0.29.1",
+    "react": "^18.2.0",
+    "react-redux": "^9.1.1"
+  },
+  "devDependencies": {
+    "@types/dockerode": "^3.3.28",
+    "@types/dockerode-compose": "^1.4.1",
+    "@types/ink-testing-library": "^1.0.4",
+    "@types/ramda": "^0.29.12",
+    "@types/react": "^18.0.32",
+    "@typescript-eslint/eslint-plugin": "^6.10.0",
+    "@typescript-eslint/parser": "^6.10.0",
+    "ava": "^5.2.0",
+    "chalk": "^5.2.0",
+    "eslint": "^8.40.0",
+    "eslint-plugin-import": "^2.29.0",
+    "eslint-plugin-prettier": "^5.0.1",
+    "eslint-plugin-react": "^7.32.2",
+    "eslint-plugin-react-hooks": "^4.6.0",
+    "eslint-plugin-unused-imports": "^3.1.0",
+    "ink-testing-library": "^3.0.0",
+    "prettier": "^3.0.3",
+    "ts-node": "^10.9.1",
+    "typescript": "5.3.3"
+  },
+  "ava": {
+    "extensions": {
+      "ts": "module",
+      "tsx": "module"
+    },
+    "nodeArguments": [
+      "--loader=ts-node/esm"
+    ]
+  }
 }

cli/tsconfig.dev.json

@@ -1,6 +1,6 @@
 {
-	"extends": "./tsconfig.json",
-	"compilerOptions": {
-			"jsx": "react-jsxdev"
-	}
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "jsx": "react-jsxdev"
+  }
 }

cli/tsconfig.json

@@ -1,34 +1,30 @@
 {
-	"compilerOptions": {
-		"outDir": "dist",
-		"allowJs": true,
+  "compilerOptions": {
+    "outDir": "dist",
+    "allowJs": true,
     "allowSyntheticDefaultImports": true,
     "jsx": "react-jsx",
     "module": "Node16",
     "moduleResolution": "Node16",
-		"moduleDetection": "force",
-		"target": "ES2022",
-		"lib": [
-			"DOM",
-			"DOM.Iterable",
-			"ES2022"
-		],
-		"resolveJsonModule": false,
-		"declaration": true,
-		"pretty": true,
-		"newLine": "lf",
-		"stripInternal": true,
-		"strict": true,
-		"noImplicitReturns": true,
-		"noImplicitOverride": true,
-		"noFallthroughCasesInSwitch": true,
-		"noUncheckedIndexedAccess": true,
-		"noPropertyAccessFromIndexSignature": true,
-		"noEmitOnError": true,
-		"useDefineForClassFields": true,
-		"forceConsistentCasingInFileNames": true,
-		"skipLibCheck": true,
-		"strictNullChecks": true
-	},
-	"include": ["source"],
+    "moduleDetection": "force",
+    "target": "ES2022",
+    "lib": ["DOM", "DOM.Iterable", "ES2022"],
+    "resolveJsonModule": false,
+    "declaration": true,
+    "pretty": true,
+    "newLine": "lf",
+    "stripInternal": true,
+    "strict": true,
+    "noImplicitReturns": true,
+    "noImplicitOverride": true,
+    "noFallthroughCasesInSwitch": true,
+    "noUncheckedIndexedAccess": true,
+    "noPropertyAccessFromIndexSignature": true,
+    "noEmitOnError": true,
+    "useDefineForClassFields": true,
+    "forceConsistentCasingInFileNames": true,
+    "skipLibCheck": true,
+    "strictNullChecks": true
+  },
+  "include": ["source"]
 }

web-server/.eslintrc.js

@@ -27,6 +27,11 @@ module.exports = {
     }
   },
   rules: {
+    quotes: [
+      'warn',
+      'single',
+      { avoidEscape: true, allowTemplateLiterals: true }
+    ],
     'no-unsafe-optional-chaining': [
       'error',
       { disallowArithmeticOperators: true }

web-server/.vscode/extensions.json

@@ -1,6 +1,3 @@
 {
-  "recommendations": [
-    "gruntfuggly.todo-tree",
-    "stringham.copy-with-imports"
-  ]
+  "recommendations": ["gruntfuggly.todo-tree", "stringham.copy-with-imports"]
 }

web-server/.vscode/settings.json

@@ -1,8 +1,10 @@
 {
   "workbench.editor.labelFormat": "short",
   "editor.codeActionsOnSave": {
-    "source.fixAll.eslint": "explicit"
+    "source.fixAll.eslint": "always"
   },
+  "editor.formatOnSave": false,
+  "eslint.workingDirectories": [{ "mode": "auto" }],
   "tsEssentialPlugins.autoImport.changeSorting": {
     "track": ["@/constants/events"],
     "useTheme": ["@mui/material"],
@@ -22,5 +24,5 @@
     "pagerduty",
     "Serie",
     "zenduty"
-  ],
+  ]
 }

web-server/app/api/stream/route.ts

@@ -210,4 +210,4 @@ export async function GET(): Promise<Response> {
 // It forces the route to be dynamically rendered on each request, which is crucial for our
 // real-time streaming functionality. Without this, Next.js might try to pre-render the route
 // during build time, leading to timeouts or incorrect behavior.
-export const dynamic = "force-dynamic";
+export const dynamic = 'force-dynamic';

web-server/libdefs/ambient.d.ts

@@ -84,6 +84,6 @@ declare namespace NodeJS {
     DB_USER: string;
     MERGE_COMMIT_SHA: string;
     BUILD_DATE: string;
-    BEHIND_COMMITS_COUNT?: string
+    BEHIND_COMMITS_COUNT?: string;
   }
 }

web-server/pages/404.tsx

@@ -1,9 +1,10 @@
 import { Box, Typography, Container, Button, styled } from '@mui/material';
 import Head from 'next/head';
-import type { ReactElement } from 'react';
 
 import { FlexBox } from '@/components/FlexBox';
 
+import type { ReactElement } from 'react';
+
 const MainContent = styled(Box)(
   () => `
     height: 100%;

web-server/pages/_app.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @next/next/no-sync-scripts */
 import { CacheProvider, EmotionCache } from '@emotion/react';
 import CssBaseline from '@mui/material/CssBaseline';
 import { LocalizationProvider } from '@mui/x-date-pickers';

web-server/pages/api/internal/[org_id]/settings.ts

@@ -3,6 +3,7 @@ import * as yup from 'yup';
 import { handleRequest } from '@/api-helpers/axios';
 import { Endpoint } from '@/api-helpers/global';
 import { OrgSettingsApiResponse } from '@/types/resources';
+
 import { syncReposForOrg } from './sync_repos';
 
 const pathSchema = yup.object().shape({

web-server/pages/api/internal/team/[team_id]/incident_services.ts

@@ -1,8 +1,8 @@
 import * as yup from 'yup';
 
+import { getSelectedIncidentServices } from '@/api/internal/[org_id]/incident_services';
 import { handleRequest } from '@/api-helpers/axios';
 import { Endpoint } from '@/api-helpers/global';
-import { getSelectedIncidentServices } from '@/api/internal/[org_id]/incident_services';
 import {
   TeamIncidentServicesApiResponse,
   TeamSelectedIncidentServicesBFFApiResponse,

web-server/pages/api/internal/version.ts

@@ -1,6 +1,7 @@
-import { Endpoint, nullSchema } from '@/api-helpers/global';
 import axios from 'axios';
 
+import { Endpoint, nullSchema } from '@/api-helpers/global';
+
 const dockerRepoName = 'middlewareeng/middleware';
 const githubOrgName = 'middlewarehq';
 const githubRepoName = 'middleware';
@@ -111,8 +112,7 @@ function isUpdateAvailable({
   localVersionInfo: ProjectVersionInfo;
   dockerLatestRemoteTag: TagCompressed;
 }): boolean {
-
-  const estimatesBuildTimeInMs: number = 30*60*1000;
+  const estimatesBuildTimeInMs: number = 30 * 60 * 1000;
 
   const env = process.env.NEXT_PUBLIC_APP_ENVIRONMENT;
 
@@ -125,15 +125,16 @@ function isUpdateAvailable({
 
   const localBuildDate = new Date(localVersionInfo.current_build_date);
   const latestRemoteDate = new Date(dockerLatestRemoteTag.last_updated);
-  return latestRemoteDate.getTime() - localBuildDate.getTime() > estimatesBuildTimeInMs;
+  return (
+    latestRemoteDate.getTime() - localBuildDate.getTime() >
+    estimatesBuildTimeInMs
+  );
 }
 
 async function checkNewImageRelease(): Promise<CheckNewVersionResponse> {
   const versionInfo = getProjectVersionInfo();
 
-  const [dockerRemoteTags] = await Promise.all([
-    fetchDockerHubTags(),
-  ]);
+  const [dockerRemoteTags] = await Promise.all([fetchDockerHubTags()]);
 
   dockerRemoteTags.sort(
     (a, b) =>