-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
innodb status metrics for mysql reciever #54
Conversation
There is a dependency of this PR, innoParser, which is used to parse the metrics and generate the metadata entries. Once a PR for that parser is merged we'll need to change go.mod files to point to the innoParser's main branch. |
receiver/mysqlreceiver/client.go
Outdated
total_errs := 0 | ||
for key, val := range errs { | ||
if errs[key][0] != nil { | ||
fmt.Println(val) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No fmt.Println
. Either use a proper logging library or let caller handle displaying of error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I'll change the print statements, to proper logging statements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we are returning all the errors, and let scraper handle error.
receiver/mysqlreceiver/scraper.go
Outdated
return | ||
} | ||
|
||
fmt.Println(innodbStatusStats) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, no fmt.Println
For a few last commits. We have came up with a way to handle errors. The getInnodbStatusStats() method has two types of errors. |
Also the Parser is now merged in the Innoparser repo, so need to change the go.mod to point at the main branch instead of the "adding-parser-WIP" branch. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description:
ENG: 2320
Added support for new Innodb metrics. Used a new parser as a package for parsing these innodb status metrics. The parser package also has a exporter that can export the entries of metrics for the metadata.yaml, so that we don't need to manually make those entries.
Testing::
Added scrapper tests for successful scrapes.