Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR generated from the context to adding metrics that are not supported by otel itself. The idea being querying the server variables of mysql to create metrics, meanwhile documenting the process of adding a new metric itself.
This PR adds a metric called mysql.innodb.mem_total, indicates the total memory used by the innodb. As of the current state of the PR, the metric is added successfully and the same is reflected by the running mw-agent, however might need some insights in testing as one test (scrape-has-partial-failure) is failing.
Initial investigations reveal that this is due to the discrepancy in the number of
actualMetrics
(2:mysql.buffer_pool.pages
andmysql.innodb.mem_total
) andexpectedMetrics
(1:mysql.buffer_pool.pages
). Currently digging in for the reasons for this mismatch.