Partial scrape test passing

middleware-labs · Apr 4, 2024 · bd50874 · bd50874
1 parent 4d558ea
commit bd50874
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/receiver/mysqlreceiver/client.go b/receiver/mysqlreceiver/client.go
@@ -244,6 +244,7 @@ func (c *mySQLClient) getInnodbStatus() (int64, error) {
 	query := "SHOW ENGINE INNODB STATUS;"
 	row := c.client.QueryRow(query)
 	err := row.Scan(&typeVar, &name, &status)
+	// TODO: Suggest better value if there's an error for the metric.
 	if err != nil {
 		return -1, err
 	}

diff --git a/receiver/mysqlreceiver/scraper_test.go b/receiver/mysqlreceiver/scraper_test.go
@@ -112,6 +112,7 @@ func TestScrape(t *testing.T) {
 
 		expectedFile := filepath.Join("testdata", "scraper", "expected_partial.yaml")
 		expectedMetrics, err := golden.ReadMetrics(expectedFile)
+
 		require.NoError(t, err)
 		assert.NoError(t, pmetrictest.CompareMetrics(actualMetrics, expectedMetrics,
 			pmetrictest.IgnoreMetricDataPointsOrder(), pmetrictest.IgnoreStartTimestamp(),

diff --git a/receiver/mysqlreceiver/testdata/scraper/expected_partial.yaml b/receiver/mysqlreceiver/testdata/scraper/expected_partial.yaml
@@ -19,6 +19,15 @@ resourceMetrics:
                   startTimeUnixNano: "1000000"
                   timeUnixNano: "2000000"
             unit: "1"
+          - description: Total memory used by InnoDB, as shown in the BUFFER POOL AND MEMORY section of SHOW ENGINE INNODB STATUS.
+            name: mysql.innodb.mem_total
+            gauge:
+              dataPoints:
+                - asInt: "-1"
+                  startTimeUnixNano: "1000000"
+                  timeUnixNano: "2000000"
+            unit: By
         scope:
           name: otelcol/mysqlreceiver
           version: latest
+