Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JHU_UNC-flepiMoP round 18 results #284

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

saraloo
Copy link
Contributor

@saraloo saraloo commented May 19, 2024

Uploading round 18 results. Local validation worked. Combined file size was annoyingly just over 100MB so partitioned.

Note that I copied the code in the instructions on partitioning - but let me know if the partitioning isn't in the right format or anything (eg wasn't sure about the 0 in the end of the parquet file names?).

Second note - we've made the change from JHU_IDD-CovidSP to JHU_UNC-flepiMoP.

Copy link

Run validation on files: 2024-04-28/cum death/2024-04-28-JHU_UNC-flepiMoP0.gz.parquet, 2024-04-28/cum hosp/2024-04-28-JHU_UNC-flepiMoP0.gz.parquet, 2024-04-28/inc death/2024-04-28-JHU_UNC-flepiMoP0.gz.parquet, 2024-04-28/inc hosp/2024-04-28-JHU_UNC-flepiMoP0.gz.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc death (optional), inc hosp (optional), cum death (optional), cum hosp (optional); output_type: quantile, mean.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

No errors or warnings found on Age_group

@LucieContamin
Copy link
Collaborator

Hi @saraloo,

Thanks for your submission, I just have two remarks:

  • as it's a new team-model name, I will need to have the associated metadata with it (here the JHU_IDD-CovidSP metadata, if that's help)
  • I also wanted to verify that I understand correctly the sample ID numbering: there is no stochasticity, every models runs has a different run_grouping "grouped" by age_group, location, horizon, scenario_id, and target. Is that correct?

Please let me know if any issues or questions,
Best, Lucie

@saraloo
Copy link
Contributor Author

saraloo commented May 20, 2024

Thanks Lucie! Attached is the metadata file.
And yes, confirming we are grouped across age_group, location, horizon, scenario and target.

Copy link

Run validation on files: 2024-04-28/cum death/2024-04-28-JHU_UNC-flepiMoP0.gz.parquet, 2024-04-28/cum hosp/2024-04-28-JHU_UNC-flepiMoP0.gz.parquet, 2024-04-28/inc death/2024-04-28-JHU_UNC-flepiMoP0.gz.parquet, 2024-04-28/inc hosp/2024-04-28-JHU_UNC-flepiMoP0.gz.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc death (optional), inc hosp (optional), cum death (optional), cum hosp (optional); output_type: quantile, mean.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

No errors or warnings found on Age_group

@LucieContamin LucieContamin merged commit a0a3488 into midas-network:master May 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants