Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reverts #722 #739

Merged
merged 1 commit into from
Dec 30, 2024
Merged

chore: reverts #722 #739

merged 1 commit into from
Dec 30, 2024

Conversation

baywet
Copy link
Member

@baywet baywet commented Dec 24, 2024

reverts #722

@baywet
chore: reverts #722
1deb74a 
Signed-off-by: Vincent Biret <[email protected]>
@baywet baywet requested a review from a team as a code owner December 24, 2024 14:14
@baywet baywet self-assigned this Dec 24, 2024
@baywet baywet mentioned this pull request Dec 24, 2024
Open
@Ndiritu Ndiritu merged commit 175e7ca into master Dec 30, 2024
20 checks passed
@Ndiritu Ndiritu deleted the fix/unpin-hidi branch December 30, 2024 10:40
@baywet
Copy link
Member Author

baywet commented Dec 30, 2024

@Ndiritu Sorry, I should have mentioned here that this depends on those to be merged and releases first, otherwise we're going to see regressions:

Would you mind please:

  • reverting this one
  • creating a new PR (this one effectively) and indicate the dependency clearly

@andrueastman andrueastman mentioned this pull request Jan 2, 2025
Merged
@andrueastman
Copy link
Member

PR reverted in #744

@Ndiritu Ndiritu restored the fix/unpin-hidi branch January 2, 2025 08:37
@Ndiritu Ndiritu mentioned this pull request Jan 2, 2025
Merged
5 tasks
@Ndiritu
Copy link
Contributor

Ndiritu commented Jan 2, 2025

re-created this PR with the checklist #745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ndiritu Ndiritu Ndiritu approved these changes

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baywet @andrueastman @Ndiritu